bruggie

GUI FEATURE BUG: 171705 The -N option is now configurable on the Diff -> Options...

Wed, 11 Mar 2009 22:21:53 +0000

Commit by bruggie :: r938468 kompare/trunk/KDE/kdesdk/kompare/libdialogpages/ (diffpage.cpp diffpage.h):

GUI
FEATURE
BUG: 171705 The -N option is now configurable on the Diff -> Options tab in the settings.
BUG: 162949 Same here, look for this option.

This feature was already implemented but without a GUI item to represent
it, that is why the patch is so small.

Fix debug areas in these files to have them output to the right area instead of...

Wed, 11 Mar 2009 20:52:17 +0000

Commit by bruggie :: r938424 kompare/trunk/KDE/kdesdk/kompare/ (5 files in 4 dirs):

Fix debug areas in these files to have them output to the right area instead of to default.

Some debug info when comparing. If this stops showing up it is not sorting...

Wed, 11 Mar 2009 20:45:36 +0000

Commit by bruggie :: r938419 kompare/trunk/KDE/kdesdk/kompare/libdiff2/diffmodel.cpp:

Some debug info when comparing. If this stops showing up it is not sorting right.

BUG: 186828 Fixed by copying some code from Qt and adapting it to my use case. I...

Wed, 11 Mar 2009 20:44:19 +0000

Commit by bruggie :: r938418 kompare/trunk/KDE/kdesdk/kompare/libdiff2/diffmodellist.cpp:

BUG: 186828 Fixed by copying some code from Qt and adapting it to my use case. I should not store pointers in Q3ValueList, this way it is not calling the operator< i defined but it did pointer comparison, that is why the order was so funky. Thanks David for reporting the bug to me on IRC.

Now it works and installs the headerfile... Note to self: read AND understand...

Wed, 11 Mar 2009 18:33:30 +0000

Commit by bruggie :: r938381 kompare/trunk/KDE/kdesdk/kompare/interfaces/CMakeLists.txt:

Now it works and installs the headerfile... Note to self: read AND understand examples first before commiting

Ok dont break svn... will fix for real in a minute...

Wed, 11 Mar 2009 18:29:35 +0000

Commit by bruggie :: r938379 kompare/trunk/KDE/kdesdk/kompare/interfaces/CMakeLists.txt:

Ok dont break svn... will fix for real in a minute...

BUG: 102551 Should get installed now in trunk, not backporting to 4.2.x for now...

Wed, 11 Mar 2009 18:27:28 +0000

Commit by bruggie :: r938378 kompare/trunk/KDE/kdesdk/kompare/interfaces/CMakeLists.txt:

BUG: 102551 Should get installed now in trunk, not backporting to 4.2.x for now to make sure everything is ok and still allows me to clean up the API if needed.

BUG: 139209 This is the best approach to fixing this bug. Thanks to Olivier...

Wed, 11 Mar 2009 00:09:48 +0000

Commit by bruggie :: r938013 kompare/trunk/KDE/kdesdk/kompare/libdiff2/parserbase.cpp:

BUG: 139209 This is the best approach to fixing this bug. Thanks to Olivier Trichet for supplying the patch 2 years and almost 3 months ago :(. Sorry for this incredible long time.

CCMAIL:kevin.kofler@chello.at This should fix all remaining saving related bugs...

Tue, 10 Mar 2009 23:33:52 +0000

Commit by bruggie :: r938008 kompare/trunk/KDE/kdesdk/kompare/ (10 files in 2 dirs):

CCMAIL:kevin dot kofler at chello dot at This should fix all remaining saving related bugs and save on exit annoyances. Kevin can you test this and confirm it works for you?

Missed the deadline :(( This fixes saving remotely when in comparingDirs mode.

Wed, 25 Feb 2009 00:15:51 +0000

Commit by bruggie :: r931227 kompare/trunk/KDE/kdesdk/kompare/libdiff2/komparemodellist.cpp:

Missed the deadline :(( This fixes saving remotely when in comparingDirs mode.

Fix last commit, dot and dotdot are in there as well when there are no filters...

Tue, 24 Feb 2009 23:43:48 +0000

Commit by bruggie :: r931210 kompare/trunk/KDE/kdesdk/kompare/komparepart/kompare_part.cpp:

Fix last commit, dot and dotdot are in there as well when there are no filters set.

Fix last commit, forgot that dircopy creates the directory in here that i need...

Tue, 24 Feb 2009 22:24:53 +0000

Commit by bruggie :: r931184 kompare/trunk/KDE/kdesdk/kompare/komparepart/kompare_part.cpp:

Fix last commit, forgot that dircopy creates the directory in here that i need to add so it compares the right directory.

Fix leaking an entire directory copied from a remote location and some other...

Tue, 24 Feb 2009 21:42:13 +0000

Commit by bruggie :: r931164 kompare/trunk/KDE/kdesdk/kompare/ (4 files in 2 dirs):

Fix leaking an entire directory copied from a remote location and some other small (TM) cleanups. More to come

No need to notify anyone about swapping source with destination.

Tue, 24 Feb 2009 21:35:22 +0000

Commit by bruggie :: r931115 kompare/trunk/KDE/kdesdk/kompare/libdiff2/komparemodellist.cpp:

No need to notify anyone about swapping source with destination.

Fix 2 FIXMEs regarding swapping source and destination. I did not try to compile...

Tue, 24 Feb 2009 10:51:12 +0000

Commit by bruggie :: r930812 kompare/trunk/KDE/kdesdk/kompare/libdiff2/komparemodellist.cpp:

Fix 2 FIXMEs regarding swapping source and destination. I did not try to compile this so if this breaks trunk then my apologies. I don't have a working Linux setup here and I don't know how to build KDE on windows (yet).

BUG:139212 Yes copy and paste error...

Tue, 24 Feb 2009 01:23:21 +0000

Commit by bruggie :: r930685 kompare/trunk/KDE/kdesdk/kompare/libdiff2/diffmodel.cpp:

BUG:139212 Yes copy and paste error...

Many changes related to passing filename information from the part to the...

Tue, 24 Feb 2009 01:23:07 +0000

Commit by bruggie :: r930684 kompare/trunk/KDE/kdesdk/kompare/ (3 files in 2 dirs):

Many changes related to passing filename information from the part to
the modellist. The Kompare::Infostruct was already in place to update
everyone about changes but it was not used to communicate between the
part and model this commit fixes that.

The real reason for this commit is that it fixes saving remote files.
Do not give a local URL and pretend it is a remote URL, does not work.
KIO::NetAccess::upload then simply does nothing because the file
already exists.

Refresh is fixed now. Refetch the files and dont reuse the local files
to determine the differences. Now that saving remote works it showed the
old result again. Some had already seen this, now it was easy to figure
out where it came from.

Fixed a silly copy and paste error where for the destination directory
source was used. Always fun these bugs.

Updated the caption in the titlebar to now have a " -- " to separate the
files so it is more clear which files/directories are compared. I read
somewhere in a bugreport people did not like this so fixed as well.

BUG:76904
BUG:81088
CCBUG:126870 Patch applied, second hunk not since this is not related

Forward port of Fixes for apidocs.

Tue, 24 Feb 2009 00:55:35 +0000

Commit by bruggie :: r930679 kdecore/trunk/KDE/kdelibs/kdecore/io/ktempdir.h:

Forward port of Fixes for apidocs.

Fixes for apidocs.

Tue, 24 Feb 2009 00:52:27 +0000

Commit by bruggie :: r930677 kdecore/branches/KDE/4.2/kdelibs/kdecore/io/ktempdir.h:

Fixes for apidocs.

BUG:69081 Now the right help page is called for every tab in the preferences...

Sun, 22 Feb 2009 18:17:54 +0000

Commit by bruggie :: r930135 kompare/trunk/KDE/kdesdk/kompare/ (3 files in 2 dirs):

BUG:69081 Now the right help page is called for every tab in the preferences dialog. If this does not fix it then i dont know anymore :D Thanks for the bugreport.