Parker Coates

Backport of commit 1275129. Don't bother saving state on close if the player has...

Sun, 22 Jan 2012 07:22:44 +0000

Commit by coates :: r1275131 kpat/branches/KDE/4.8/kdegames/kpat/ (dealer.h mainwindow.cpp): (link)

Backport of commit 1275129.

Don't bother saving state on close if the player has already won.

This was a behaviour regression caused by the clean up of the loading
and saving code. Somewhat surprisingly, saving after the game has been
won worked without issue and loading that save caused the player to
instantly win again, so it acted like the state was actually remembered.
Of course, the user doesn't expect to fire up KPat just to be instantly
told that they've won.

CCBUG:291959

Don't bother saving state on close if the player has already won. This was a...

Sun, 22 Jan 2012 07:15:10 +0000

Commit by coates :: r1275129 kpat/trunk/KDE/kdegames/kpat/ (dealer.h mainwindow.cpp): (link)

Don't bother saving state on close if the player has already won.

This was a behaviour regression caused by the clean up of the loading
and saving code. Somewhat surprisingly, saving after the game has been
won worked without issue and loading that save caused the player to
instantly win again, so it acted like the state was actually remembered.
Of course, the user doesn't expect to fire up KPat just to be instantly
told that they've won.

CCBUG:291959

Backport of commit 1264171. don't overfill the possible array CCBUG:283191...

Mon, 14 Nov 2011 19:15:03 +0000

Commit by coates :: r1264189 kpat/branches/KDE/4.7/kdegames/kpat/patsolve/ (gypsysolver.cpp patsolve.cpp): (link)

Backport of commit 1264171.

don't overfill the possible array
CCBUG:283191
FIXED-IN:4.7.4

Make use of the new mimetype in the load and save dialogs. File dialogs are now...

Tue, 08 Nov 2011 09:54:14 +0000

Commit by coates :: r1263113 kpat/trunk/KDE/kdegames/kpat/mainwindow.cpp: (link)

Make use of the new mimetype in the load and save dialogs.

File dialogs are now filtered by default to only show KPat save files.
The save dialog now automatically adds the .kpatience extension.

CCBUG:286074

Add a mimetype for KPat saved games. I'm not really sure why this wasn't done a...

Tue, 08 Nov 2011 09:54:12 +0000

Commit by coates :: r1263112 kpat/trunk/KDE/kdegames/kpat/ (5 files in 2 dirs): (link)

Add a mimetype for KPat saved games.

I'm not really sure why this wasn't done a long time ago, but KPat
saved games now have their own mimetype: vnd.kde.kpatience.savedstate.
The files are identified by having either a .kpatience file extension
or a "kpat" XML DOCTYPE. Clicking on saved games should now launch KPat
to open them, as well.

BUG:286074
FIXED-IN:4.8

Rename the MainWindow::openGame() methods to loadGame(). I just like to have the...

Tue, 08 Nov 2011 09:54:09 +0000

Commit by coates :: r1263111 kpat/trunk/KDE/kdegames/kpat/ (main.cpp mainwindow.cpp mainwindow.h): (link)

Rename the MainWindow::openGame() methods to loadGame().

I just like to have the terminology of the code match the terminology of
the UI.

Clean up save file opening and saving code. Relying on the...

Tue, 08 Nov 2011 09:54:06 +0000

Commit by coates :: r1263110 kpat/trunk/KDE/kdegames/kpat/ (4 files): (link)

Clean up save file opening and saving code.

Relying on the DealerScene::save_it() to return the name of a temporary
file wasn't very nice or clean API. Now all temporary files, downloads,
uploads and local files are handled by MainWindow while DealerScene only
loads from and saves to QIODevices.

Don't delete the saved state file after opening it. In case of a crash, it seems...

Tue, 08 Nov 2011 09:54:03 +0000

Commit by coates :: r1263109 kpat/trunk/KDE/kdegames/kpat/main.cpp: (link)

Don't delete the saved state file after opening it.

In case of a crash, it seems much friendlier to leave the saved state
file on disk, so the player at least has a chance to restart from there.

Remove a bunch of cruft from DealerScene::demo(). This code was doing a bunch of...

Mon, 07 Nov 2011 06:58:05 +0000

Commit by coates :: r1262923 kpat/trunk/KDE/kdegames/kpat/ (dealer.cpp hint.h): (link)

Remove a bunch of cruft from DealerScene::demo().

This code was doing a bunch of things suboptimally. It didn't use
KCardPile::topCardsDownTo(). It handled a bunch of animation stuff
that should now be handled automatically. It asserted pointers after
having used them, which is pointless.

While I don't know what was causing the crash in bug 274127, I do know
it can't happen again with the new code.

BUG:274127

Backport of commit 1260924. Make Renderer a pseudo-singleton to avoid crashes on...

Thu, 27 Oct 2011 05:53:11 +0000

Commit by coates :: r1260926 kpat/branches/KDE/4.7/kdegames/kpat/ (mainwindow.cpp renderer.cpp renderer.h): (link)

Backport of commit 1260924.

Make Renderer a pseudo-singleton to avoid crashes on logout.

An in depth description of the issue can be found here:
http://lists.kde.org/?l=kde-games-devel&m=130499552229629

This commit sidesteps the basic issue by avoiding the use of a
K_GLOBAL_STATIC.

BUG:271655
FIXED-IN:4.7.3

Make Renderer a pseudo-singleton to avoid crashes on logout. An in depth...

Thu, 27 Oct 2011 05:32:09 +0000

Commit by coates :: r1260924 kpat/trunk/KDE/kdegames/kpat/ (mainwindow.cpp renderer.cpp renderer.h): (link)

Make Renderer a pseudo-singleton to avoid crashes on logout.

An in depth description of the issue can be found here:
http://lists.kde.org/?l=kde-games-devel&m=130499552229629

This commit sidesteps the basic issue by avoiding the use of a
K_GLOBAL_STATIC.

CCBUG:271655

Backport of commit 1260491. Check that the top card in a Spider run is face up....

Tue, 25 Oct 2011 07:01:04 +0000

Commit by coates :: r1260492 kpat/branches/KDE/4.7/kdegames/kpat/spider.cpp: (link)

Backport of commit 1260491.

Check that the top card in a Spider run is face up.

Very similar to bugs 260748 and 265857. This makes me worry that we have
even more rare bugs caused by not checking if cards are face up.

CCBUG:283519

Check that the top card in a Spider run is face up. Very similar to bugs 260748...

Tue, 25 Oct 2011 06:58:28 +0000

Commit by coates :: r1260491 kpat/trunk/KDE/kdegames/kpat/spider.cpp: (link)

Check that the top card in a Spider run is face up.

Very similar to bugs 260748 and 265857. This makes me worry that we have
even more rare bugs caused by not checking if cards are face up.

BUG:283519
FIXED-IN:4.7.3

Properly grab the state during Golf autodrop. CCBUG:270532

Tue, 25 Oct 2011 05:41:35 +0000

Commit by coates :: r1260488 kpat/branches/KDE/4.7/kdegames/kpat/golf.cpp: (link)

Properly grab the state during Golf autodrop.

CCBUG:270532

Properly grab the state during Golf autodrop. BUG:270532

Tue, 25 Oct 2011 05:37:35 +0000

Commit by coates :: r1260487 kpat/trunk/KDE/kdegames/kpat/golf.cpp: (link)

Properly grab the state during Golf autodrop.

BUG:270532

Minor cleanup of KCardScenePrivate::sendCardsToPile(). * Renamed some variables....

Sun, 01 May 2011 03:55:13 +0000

Commit by coates :: r1229904 kpat/trunk/KDE/kdegames/kpat/libkcardgame/kcardscene.cpp: (link)

Minor cleanup of KCardScenePrivate::sendCardsToPile().

 * Renamed some variables.
 * Got rid of an unused QList.
 * Added some comments.
 * Shuffled some code around.

Correct card ordering in KCardScene::flipCardsToPile(). When flipping multiple...

Sun, 01 May 2011 03:55:02 +0000

Commit by coates :: r1229903 kpat/trunk/KDE/kdegames/kpat/libkcardgame/kcardscene.cpp: (link)

Correct card ordering in KCardScene::flipCardsToPile().

When flipping multiple cards from one pile to another, we have to
reverse the stacking order of the cards. The topmost card on the source
pile becomes the bottommost card on the destination pile. This fixes
the waste to stock recycling in both Klondike and Forty & Eight.

The previous behaviour wasn't necessarily wrong, but it did represent a
maneuver that can't really be done with real cards in a single move,
hence it wasn't the correct behaviour for the games in question.

Backport of commit 1228140. Make the Spider solver check all cards are face up...

Sat, 16 Apr 2011 03:06:03 +0000

Commit by coates :: r1228141 kpat/branches/KDE/4.6/kdegames/kpat/patsolve/spidersolver.cpp: (link)

Backport of commit 1228140.

Make the Spider solver check all cards are face up before moving runs.

This was simply a missing check.

CCBUG:265857
FIXED-IN:SC4.6.3

Make the Spider solver check all cards are face up before moving runs. This was...

Sat, 16 Apr 2011 02:54:53 +0000

Commit by coates :: r1228140 kpat/trunk/KDE/kdegames/kpat/patsolve/spidersolver.cpp: (link)

Make the Spider solver check all cards are face up before moving runs.

This was simply a missing check.

BUG:265857

Remove assert from Dealer destructor to fix the last commit. I didn't mean to...

Thu, 24 Mar 2011 17:16:57 +0000

Commit by coates :: r1225910 kpat/trunk/KDE/kdegames/kpat/dealer.cpp: (link)

Remove assert from Dealer destructor to fix the last commit.

I didn't mean to commit the change to dealer.cpp in the last commit.
That change was a bad idea and will cause asserts when changing games
or shutting down.