http://cia.vc/stats/author/coates11062NoneNoneNoneParker CoatesNoneNoneSubversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id AB9E72E71F
for <cia@cia.navi.cx>; Sat, 21 Jan 2012 23:22:44 -0800 (PST)by svn.kde.org (Postfix, from userid 50276)
id 78100AC894; Sun, 22 Jan 2012 05:08:37 +0100 (CET)sysadmin@kde.org<20120122040837.78100AC894@svn.kde.org>Sun, 22 Jan 2012 05:08:37 +0100 (CET)KDEkpat1275131coatesbranches/KDE/4.8/kdegames/kpat/dealer.hbranches/KDE/4.8/kdegames/kpat/mainwindow.cppBackport of commit 1275129.
Don't bother saving state on close if the player has already won.
This was a behaviour regression caused by the clean up of the loading
and saving code. Somewhat surprisingly, saving after the game has been
won worked without issue and loading that save caused the player to
instantly win again, so it acted like the state was actually remembered.
Of course, the user doesn't expect to fire up KPat just to be instantly
told that they've won.
CCBUG:29195959http://websvn.kde.org/?view=revision&revision=12751311327216964Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id A272A2E71D
for <cia@cia.navi.cx>; Sat, 21 Jan 2012 23:15:07 -0800 (PST)by svn.kde.org (Postfix, from userid 50276)
id 40E12AC894; Sun, 22 Jan 2012 05:00:55 +0100 (CET)sysadmin@kde.org<20120122040055.40E12AC894@svn.kde.org>Sun, 22 Jan 2012 05:00:55 +0100 (CET)KDEkpat1275129coatestrunk/KDE/kdegames/kpat/dealer.htrunk/KDE/kdegames/kpat/mainwindow.cppDon't bother saving state on close if the player has already won.
This was a behaviour regression caused by the clean up of the loading
and saving code. Somewhat surprisingly, saving after the game has been
won worked without issue and loading that save caused the player to
instantly win again, so it acted like the state was actually remembered.
Of course, the user doesn't expect to fire up KPat just to be instantly
told that they've won.
CCBUG:29195959http://websvn.kde.org/?view=revision&revision=12751291327216510Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 7BEA4232930
for <cia@cia.navi.cx>; Mon, 14 Nov 2011 11:15:03 -0800 (PST)by svn.kde.org (Postfix, from userid 50276)
id 55A9FAC88D; Mon, 14 Nov 2011 17:39:54 +0100 (CET)sysadmin@kde.org<20111114163954.55A9FAC88D@svn.kde.org>Mon, 14 Nov 2011 17:39:54 +0100 (CET)KDEkpat1264189coatesbranches/KDE/4.7/kdegames/kpat/patsolve/gypsysolver.cppbranches/KDE/4.7/kdegames/kpat/patsolve/patsolve.cppBackport of commit 1264171.
don't overfill the possible array
CCBUG:283191
FIXED-IN:4.7.480http://websvn.kde.org/?view=revision&revision=12641891321298103Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 211CA23292E
for <cia@cia.navi.cx>; Tue, 8 Nov 2011 01:54:14 -0800 (PST)by svn.kde.org (Postfix, from userid 50276)
id 231EBAC88E; Tue, 8 Nov 2011 08:22:43 +0100 (CET)sysadmin@kde.org<20111108072243.231EBAC88E@svn.kde.org>Tue, 8 Nov 2011 08:22:43 +0100 (CET)KDEkpat1263113coatestrunk/KDE/kdegames/kpat/mainwindow.cppMake use of the new mimetype in the load and save dialogs.
File dialogs are now filtered by default to only show KPat save files.
The save dialog now automatically adds the .kpatience extension.
CCBUG:28607459http://websvn.kde.org/?view=revision&revision=12631131320746054Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 1A06323292E
for <cia@cia.navi.cx>; Tue, 8 Nov 2011 01:54:12 -0800 (PST)by svn.kde.org (Postfix, from userid 50276)
id 1FF9DAC88E; Tue, 8 Nov 2011 08:22:41 +0100 (CET)sysadmin@kde.org<20111108072241.1FF9DAC88E@svn.kde.org>Tue, 8 Nov 2011 08:22:41 +0100 (CET)KDEkpat1263112coatestrunk/KDE/kdegames/kpat/CMakeLists.txttrunk/KDE/kdegames/kpat/kpat.desktoptrunk/KDE/kdegames/kpat/mimetypes/trunk/KDE/kdegames/kpat/mimetypes/CMakeLists.txttrunk/KDE/kdegames/kpat/mimetypes/kpatience.xmlAdd a mimetype for KPat saved games.
I'm not really sure why this wasn't done a long time ago, but KPat
saved games now have their own mimetype: vnd.kde.kpatience.savedstate.
The files are identified by having either a .kpatience file extension
or a "kpat" XML DOCTYPE. Clicking on saved games should now launch KPat
to open them, as well.
BUG:286074
FIXED-IN:4.850http://websvn.kde.org/?view=revision&revision=12631121320746052Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 48E1723292E
for <cia@cia.navi.cx>; Tue, 8 Nov 2011 01:54:09 -0800 (PST)by svn.kde.org (Postfix, from userid 50276)
id 51E23AC88C; Tue, 8 Nov 2011 08:22:38 +0100 (CET)sysadmin@kde.org<20111108072238.51E23AC88C@svn.kde.org>Tue, 8 Nov 2011 08:22:38 +0100 (CET)KDEkpat1263111coatestrunk/KDE/kdegames/kpat/main.cpptrunk/KDE/kdegames/kpat/mainwindow.cpptrunk/KDE/kdegames/kpat/mainwindow.hRename the MainWindow::openGame() methods to loadGame().
I just like to have the terminology of the code match the terminology of
the UI.85http://websvn.kde.org/?view=revision&revision=12631111320746049Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id B78E423292E
for <cia@cia.navi.cx>; Tue, 8 Nov 2011 01:54:06 -0800 (PST)by svn.kde.org (Postfix, from userid 50276)
id B7728AC88C; Tue, 8 Nov 2011 08:22:35 +0100 (CET)sysadmin@kde.org<20111108072235.B7728AC88C@svn.kde.org>Tue, 8 Nov 2011 08:22:35 +0100 (CET)KDEkpat1263110coatestrunk/KDE/kdegames/kpat/dealer.cpptrunk/KDE/kdegames/kpat/dealer.htrunk/KDE/kdegames/kpat/main.cpptrunk/KDE/kdegames/kpat/mainwindow.cppClean up save file opening and saving code.
Relying on the DealerScene::save_it() to return the name of a temporary
file wasn't very nice or clean API. Now all temporary files, downloads,
uploads and local files are handled by MainWindow while DealerScene only
loads from and saves to QIODevices.396http://websvn.kde.org/?view=revision&revision=12631101320746046Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id A39E423292E
for <cia@cia.navi.cx>; Tue, 8 Nov 2011 01:54:02 -0800 (PST)by svn.kde.org (Postfix, from userid 50276)
id 3E792AC88B; Tue, 8 Nov 2011 08:22:31 +0100 (CET)sysadmin@kde.org<20111108072231.3E792AC88B@svn.kde.org>Tue, 8 Nov 2011 08:22:31 +0100 (CET)KDEkpat1263109coatestrunk/KDE/kdegames/kpat/main.cppDon't delete the saved state file after opening it.
In case of a crash, it seems much friendlier to leave the saved state
file on disk, so the player at least has a chance to restart from there.13http://websvn.kde.org/?view=revision&revision=12631091320746043Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id C6BB123292E
for <cia@cia.navi.cx>; Sun, 6 Nov 2011 22:58:04 -0800 (PST)by svn.kde.org (Postfix, from userid 50276)
id B5E9CAC88C; Mon, 7 Nov 2011 05:27:11 +0100 (CET)sysadmin@kde.org<20111107042711.B5E9CAC88C@svn.kde.org>Mon, 7 Nov 2011 05:27:11 +0100 (CET)KDEkpat1262923coatestrunk/KDE/kdegames/kpat/dealer.cpptrunk/KDE/kdegames/kpat/hint.hRemove a bunch of cruft from DealerScene::demo().
This code was doing a bunch of things suboptimally. It didn't use
KCardPile::topCardsDownTo(). It handled a bunch of animation stuff
that should now be handled automatically. It asserted pointers after
having used them, which is pointless.
While I don't know what was causing the crash in bug 274127, I do know
it can't happen again with the new code.
BUG:27412796http://websvn.kde.org/?view=revision&revision=12629231320649085Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 9048523292C
for <cia@cia.navi.cx>; Wed, 26 Oct 2011 22:53:11 -0700 (PDT)by svn.kde.org (Postfix, from userid 50276)
id 3D386AC88A; Thu, 27 Oct 2011 05:28:36 +0200 (CEST)sysadmin@kde.org<20111027032836.3D386AC88A@svn.kde.org>Thu, 27 Oct 2011 05:28:36 +0200 (CEST)KDEkpat1260926coatesbranches/KDE/4.7/kdegames/kpat/mainwindow.cppbranches/KDE/4.7/kdegames/kpat/renderer.cppbranches/KDE/4.7/kdegames/kpat/renderer.hBackport of commit 1260924.
Make Renderer a pseudo-singleton to avoid crashes on logout.
An in depth description of the issue can be found here:
http://lists.kde.org/?l=kde-games-devel&m=130499552229629
This commit sidesteps the basic issue by avoiding the use of a
K_GLOBAL_STATIC.
BUG:271655
FIXED-IN:4.7.372http://websvn.kde.org/?view=revision&revision=12609261319694791Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 9932F23292C
for <cia@cia.navi.cx>; Wed, 26 Oct 2011 22:32:09 -0700 (PDT)by svn.kde.org (Postfix, from userid 50276)
id D8AE2AC88B; Thu, 27 Oct 2011 05:07:30 +0200 (CEST)sysadmin@kde.org<20111027030730.D8AE2AC88B@svn.kde.org>Thu, 27 Oct 2011 05:07:30 +0200 (CEST)KDEkpat1260924coatestrunk/KDE/kdegames/kpat/mainwindow.cpptrunk/KDE/kdegames/kpat/renderer.cpptrunk/KDE/kdegames/kpat/renderer.hMake Renderer a pseudo-singleton to avoid crashes on logout.
An in depth description of the issue can be found here:
http://lists.kde.org/?l=kde-games-devel&m=130499552229629
This commit sidesteps the basic issue by avoiding the use of a
K_GLOBAL_STATIC.
CCBUG:27165572http://websvn.kde.org/?view=revision&revision=12609241319693529Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 6036E23292C
for <cia@cia.navi.cx>; Tue, 25 Oct 2011 00:01:04 -0700 (PDT)by svn.kde.org (Postfix, from userid 50276)
id 90A8EAC88A; Tue, 25 Oct 2011 06:37:35 +0200 (CEST)sysadmin@kde.org<20111025043735.90A8EAC88A@svn.kde.org>Tue, 25 Oct 2011 06:37:35 +0200 (CEST)KDEkpat1260492coatesbranches/KDE/4.7/kdegames/kpat/spider.cppBackport of commit 1260491.
Check that the top card in a Spider run is face up.
Very similar to bugs 260748 and 265857. This makes me worry that we have
even more rare bugs caused by not checking if cards are face up.
CCBUG:28351917http://websvn.kde.org/?view=revision&revision=12604921319526064Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 34DDB23292C
for <cia@cia.navi.cx>; Mon, 24 Oct 2011 23:58:28 -0700 (PDT)by svn.kde.org (Postfix, from userid 50276)
id 5067DAC88A; Tue, 25 Oct 2011 06:34:59 +0200 (CEST)sysadmin@kde.org<20111025043459.5067DAC88A@svn.kde.org>Tue, 25 Oct 2011 06:34:59 +0200 (CEST)KDEkpat1260491coatestrunk/KDE/kdegames/kpat/spider.cppCheck that the top card in a Spider run is face up.
Very similar to bugs 260748 and 265857. This makes me worry that we have
even more rare bugs caused by not checking if cards are face up.
BUG:283519
FIXED-IN:4.7.317http://websvn.kde.org/?view=revision&revision=12604911319525908Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id E7AD223292D
for <cia@cia.navi.cx>; Mon, 24 Oct 2011 22:41:34 -0700 (PDT)by svn.kde.org (Postfix, from userid 50276)
id 0712EAC88A; Tue, 25 Oct 2011 05:18:08 +0200 (CEST)sysadmin@kde.org<20111025031808.0712EAC88A@svn.kde.org>Tue, 25 Oct 2011 05:18:08 +0200 (CEST)KDEkpat1260488coatesbranches/KDE/4.7/kdegames/kpat/golf.cppProperly grab the state during Golf autodrop.
CCBUG:27053213http://websvn.kde.org/?view=revision&revision=12604881319521295Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id A49F423292C
for <cia@cia.navi.cx>; Mon, 24 Oct 2011 22:37:35 -0700 (PDT)by svn.kde.org (Postfix, from userid 50276)
id D317CAC88A; Tue, 25 Oct 2011 05:14:08 +0200 (CEST)sysadmin@kde.org<20111025031408.D317CAC88A@svn.kde.org>Tue, 25 Oct 2011 05:14:08 +0200 (CEST)KDEkpat1260487coatestrunk/KDE/kdegames/kpat/golf.cppProperly grab the state during Golf autodrop.
BUG:27053213http://websvn.kde.org/?view=revision&revision=12604871319521055Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id E7ADF1D83C7
for <cia@cia.navi.cx>; Sat, 30 Apr 2011 20:55:01 -0700 (PDT)by svn.kde.org (Postfix, from userid 50276)
id 141CEAC873; Sun, 1 May 2011 05:54:51 +0200 (CEST)sysadmin@kde.org<20110501035451.141CEAC873@svn.kde.org>Sun, 1 May 2011 05:54:51 +0200 (CEST)KDEkpat1229904coatestrunk/KDE/kdegames/kpat/libkcardgame/kcardscene.cppMinor cleanup of KCardScenePrivate::sendCardsToPile().
* Renamed some variables.
* Got rid of an unused QList.
* Added some comments.
* Shuffled some code around.106http://websvn.kde.org/?view=revision&revision=12299041304222113Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 3A35D1D83AA
for <cia@cia.navi.cx>; Sat, 30 Apr 2011 20:55:00 -0700 (PDT)by svn.kde.org (Postfix, from userid 50276)
id E49D6AC869; Sun, 1 May 2011 05:54:48 +0200 (CEST)sysadmin@kde.org<20110501035448.E49D6AC869@svn.kde.org>Sun, 1 May 2011 05:54:48 +0200 (CEST)KDEkpat1229903coatestrunk/KDE/kdegames/kpat/libkcardgame/kcardscene.cppCorrect card ordering in KCardScene::flipCardsToPile().
When flipping multiple cards from one pile to another, we have to
reverse the stacking order of the cards. The topmost card on the source
pile becomes the bottommost card on the destination pile. This fixes
the waste to stock recycling in both Klondike and Forty & Eight.
The previous behaviour wasn't necessarily wrong, but it did represent a
maneuver that can't really be done with real cards in a single move,
hence it wasn't the correct behaviour for the games in question.18http://websvn.kde.org/?view=revision&revision=12299031304222102Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id AEC641D81E0
for <cia@cia.navi.cx>; Fri, 15 Apr 2011 20:06:02 -0700 (PDT)by svn.kde.org (Postfix, from userid 50276)
id 5E8E1AC8D3; Sat, 16 Apr 2011 05:05:51 +0200 (CEST)sysadmin@kde.org<20110416030551.5E8E1AC8D3@svn.kde.org>Sat, 16 Apr 2011 05:05:51 +0200 (CEST)KDEkpat1228141coatesbranches/KDE/4.6/kdegames/kpat/patsolve/spidersolver.cppBackport of commit 1228140.
Make the Spider solver check all cards are face up before moving runs.
This was simply a missing check.
CCBUG:265857
FIXED-IN:SC4.6.315http://websvn.kde.org/?view=revision&revision=12281411302923163Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 868FA1D81E0
for <cia@cia.navi.cx>; Fri, 15 Apr 2011 19:54:53 -0700 (PDT)by svn.kde.org (Postfix, from userid 50276)
id 7CC22AC8D4; Sat, 16 Apr 2011 04:54:32 +0200 (CEST)sysadmin@kde.org<20110416025432.7CC22AC8D4@svn.kde.org>Sat, 16 Apr 2011 04:54:32 +0200 (CEST)KDEkpat1228140coatestrunk/KDE/kdegames/kpat/patsolve/spidersolver.cppMake the Spider solver check all cards are face up before moving runs.
This was simply a missing check.
BUG:26585715http://websvn.kde.org/?view=revision&revision=12281401302922493Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 758A71D82B1
for <cia@cia.navi.cx>; Thu, 24 Mar 2011 10:16:57 -0700 (PDT)by svn.kde.org (Postfix, from userid 50276)
id D1587AC8CA; Thu, 24 Mar 2011 18:16:46 +0100 (CET)sysadmin@kde.org<20110324171646.D1587AC8CA@svn.kde.org>Thu, 24 Mar 2011 18:16:46 +0100 (CET)KDEkpat1225910coatestrunk/KDE/kdegames/kpat/dealer.cppRemove assert from Dealer destructor to fix the last commit.
I didn't mean to commit the change to dealer.cpp in the last commit.
That change was a bad idea and will cause asserts when changing games
or shutting down.14http://websvn.kde.org/?view=revision&revision=12259101300987017