Michael Pyne

Backport canonical path usage for m3u playlists to KDE SC 4.8.1. This backports...

Thu, 26 Jan 2012 05:50:52 +0000

Commit by mpyne :: r1275921 juk/branches/KDE/4.8/kdemultimedia/juk/playlist.cpp: (link)

Backport canonical path usage for m3u playlists to KDE SC 4.8.1.

This backports r1275919 to KDE 4.8.1. This bugfix ensures that m3u files with different
names due to symlinks do not get loaded more than once.

Backport m3u playlist fix to KDE SC 4.8.1. This backports to KDE SC 4.8.1 the...

Thu, 26 Jan 2012 05:49:29 +0000

Commit by mpyne :: r1275920 juk/branches/KDE/4.8/kdemultimedia/juk/ (cache.cpp main.cpp playlistcollection.h): (link)

Backport m3u playlist fix to KDE SC 4.8.1.

This backports to KDE SC 4.8.1 the fix given in r1275917 for .m3u playlists
being loaded in duplicate with folder scan enabled.

BUG:113769
FIXED-IN:4.8.1

Use canonicalPath for playlist m3u files. This is as opposed to absolutePath,...

Thu, 26 Jan 2012 05:46:03 +0000

Commit by mpyne :: r1275919 juk/trunk/KDE/kdemultimedia/juk/playlist.cpp: (link)

Use canonicalPath for playlist m3u files.

This is as opposed to absolutePath, which can end up adding the same playlist multiple
times when given the combination of symlinks and stupid folder scan settings.

SVN_SILENT Bump version for KDE 4.9(?)

Thu, 26 Jan 2012 05:43:52 +0000

Commit by mpyne :: r1275918 juk/trunk/KDE/kdemultimedia/juk/main.cpp: (link)

SVN_SILENT Bump version for KDE 4.9(?)

Don't load a playlist if it's already found by folder scan. The way file...

Thu, 26 Jan 2012 05:41:03 +0000

Commit by mpyne :: r1275917 juk/trunk/KDE/kdemultimedia/juk/ (cache.cpp playlistcollection.h): (link)

Don't load a playlist if it's already found by folder scan.

The way file scanning is performed, it's possible for a playlist that is stored
with a .m3u file to be found and loaded before JuK has finished loading its
cached playlists.

There's a few ways to fix this, but the most conservative (especially for those
dealing with this bug for awhile) is to filter playlists as they are being
loaded from the cache and remove any that have already been loaded. This also does not
require a change to the QDataStream binary format used for saving playlists.

This should fix a bug that's been open for more than five years now... by the
way, anyone want to help with finding/fixing more JuK bugs? :D

BUG:113769

Put the kdesrc-build 1.14.1 release on the website.

Thu, 22 Sep 2011 05:00:02 +0000

Commit by mpyne :: r1254889 /trunk/www/apps/kdesrc-build/ (6 files in 2 dirs): (link)

Put the kdesrc-build 1.14.1 release on the website.

The kdesrc-build 1.14 release page seems to be OK, expose it on the front page...

Sun, 18 Sep 2011 05:52:27 +0000

Commit by mpyne :: r1254132 /trunk/www/apps/kdesrc-build/ (index.php menu.inc site.inc): (link)

The kdesrc-build 1.14 release page seems to be OK, expose it on the front page
now.

SVN_SILENT 1.13 was called kdesrc-build, not kdesvn-build

Sun, 18 Sep 2011 05:48:24 +0000

Commit by mpyne :: r1254129 /trunk/www/apps/kdesrc-build/releases/kdesrc-build-1.14.php: (link)

SVN_SILENT 1.13 was called kdesrc-build, not kdesvn-build

Make the kdesrc-build 1.14 release.

Sun, 18 Sep 2011 04:39:14 +0000

Commit by mpyne :: r1254126 /trunk/www/apps/kdesrc-build/releases/ (3 files): (link)

Make the kdesrc-build 1.14 release.

Update kdesrc-build online docs

Thu, 08 Sep 2011 05:26:14 +0000

Commit by mpyne :: r1252064 /trunk/www/apps/kdesrc-build/documentation/ (12 files): (link)

Update kdesrc-build online docs

juk: Fix window always appearing from restored session.

Sun, 15 May 2011 00:03:39 +0000

Commit by mpyne :: r1231935 juk/trunk/KDE/kdemultimedia/juk/main.cpp: (link)

juk: Fix window always appearing from restored session.

juk: Remove KPixmapCache, more simplification. With only a few SVG elements in...

Wed, 11 May 2011 03:11:49 +0000

Commit by mpyne :: r1231346 juk/trunk/KDE/kdemultimedia/juk/ (svghandler.cpp svghandler.h): (link)

juk: Remove KPixmapCache, more simplification.

With only a few SVG elements in use, at an essentially fixed size, a cache
becomes highly overkill (and even if not, KPixmapCache has issues, although I
am biased...), so just use a simple QMap to cache generated SVG elements.

I could probably go farther (e.g. remove locking) and I'm sure there's headers
that could be removed, but I think this is fairly low-fat again in keeping with
the spirit of the code committed yesterday. :-)

juk: Dead code removal, Simplification of SVG Handler. Removed more unneeded...

Wed, 11 May 2011 02:43:52 +0000

Commit by mpyne :: r1231344 juk/trunk/KDE/kdemultimedia/juk/ (svghandler.cpp svghandler.h): (link)

juk: Dead code removal, Simplification of SVG Handler.

Removed more unneeded code in the SVG Handler, and removed the (in our case)
needless ability to have multiple SVG renderers since we only have the one
SVG theme file.

juk: Reduce SVG theme size. The previous theme SVG was basically Amarok's...

Wed, 11 May 2011 02:19:36 +0000

Commit by mpyne :: r1231341 juk/trunk/KDE/kdemultimedia/juk/pics/theme.svg: (link)

juk: Reduce SVG theme size.

The previous theme SVG was basically Amarok's default-theme-clean with excess
information mostly removed by editing in Inkscape.

For this I just manually added elements we actually use into an empty shell
XML, and any cross-referenced elements. The result is much smaller, and both
appears the same and the SVG handling code doesn't complain about missing
elements.

juk: No need to copy dead code from Amarok svg handler.

Wed, 11 May 2011 01:59:25 +0000

Commit by mpyne :: r1231340 juk/trunk/KDE/kdemultimedia/juk/svghandler.cpp: (link)

juk: No need to copy dead code from Amarok svg handler.

juk: Bump version of ui.rc files for new sliders. Unfortunately the new sliders...

Tue, 10 May 2011 22:50:44 +0000

Commit by mpyne :: r1231327 juk/trunk/KDE/kdemultimedia/juk/ (jukui-rtl.rc jukui.rc): (link)

juk: Bump version of ui.rc files for new sliders.

Unfortunately the new sliders still don't actually get integrated into
the GUI automatically from what I can tell. I wonder how this can be
fixed/forced.

juk: Check that the VolumePopupButton was created before using. For whatever...

Tue, 10 May 2011 04:04:20 +0000

Commit by mpyne :: r1231079 juk/trunk/KDE/kdemultimedia/juk/juk.cpp: (link)

juk: Check that the VolumePopupButton was created before using.

For whatever reason neither the new seek slider or the volume button actually
show up for me when I tested it (although clicking around where the seek slider
should be does work). Something related to this causes the VolumeSlider's
createWidget() method to never be run, which causes this line to crash after
dereferencing the null pointer.

Until I figure it out better (or wheels does ;) just make the crash go away.

Add JuK changelog entries for 4.6.4.

Thu, 05 May 2011 03:16:06 +0000

Commit by mpyne :: r1230448 /trunk/www/sites/www/announcements/changelogs/ (3 files): (link)

Add JuK changelog entries for 4.6.4.

Fix saving of tag editor position on shutdown. This is a backport of Giorgos...

Thu, 05 May 2011 03:07:56 +0000

Commit by mpyne :: r1230447 juk/branches/KDE/4.6/kdemultimedia/juk/playlistsplitter.cpp: (link)

Fix saving of tag editor position on shutdown.

This is a backport of Giorgos Kylafas's tag editor show/hide status saving fix
to KDE SC 4.6.4, from r1229816.

CCMAIL:gekylafas at gmail dot com

Backport history playlist crash fix to 4.6. This backports some history playlist...

Thu, 05 May 2011 03:04:18 +0000

Commit by mpyne :: r1230446 juk/branches/KDE/4.6/kdemultimedia/juk/ (main.cpp playlist.cpp): (link)

Backport history playlist crash fix to 4.6.

This backports some history playlist column handling fixes (including a crash
fix) to KDE SC 4.6.4. The source revision is r1230444.