http://cia.vc/stats/author/sstjames46Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 63B2A1D80AD
for <cia@cia.navi.cx>; Sat, 31 Oct 2009 08:47:43 -0700 (PDT)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id BCE40190
for <cia@cia.navi.cx>; Sat, 31 Oct 2009 16:47:32 +0100 (CET)(nullmailer pid 30402 invoked by uid 51645);
Sat, 31 Oct 2009 15:47:32 -0000sysadmin@kde.orgSat, 31 Oct 2009 15:47:32 +0000<1257004052.716392.30401.nullmailer@svn.kde.org>KDEkonq-plugins1043045sstjamestrunk/extragear/base/konq-plugins/fsview/fsview.cpptrunk/extragear/base/konq-plugins/fsview/fsview.htrunk/extragear/base/konq-plugins/fsview/fsview_part.cpptrunk/extragear/base/konq-plugins/fsview/fsview_part.htrunk/extragear/base/konq-plugins/fsview/treemap.cpptrunk/extragear/base/konq-plugins/fsview/treemap.hBorrow some code from Dolphin to make FSView file management operations (Move To Trash, Delete, etc) work in KDE4.
Deselect All on pressing ESC.
Minor redrawing bugfix to TreeMapWidget::clearSelection(...).
CCMAIL:peter.penz@gmx.at
BUG:1805792451257004063Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id A64481D823E
for <cia@cia.navi.cx>; Fri, 2 Oct 2009 00:02:38 -0700 (PDT)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id 14948179
for <cia@cia.navi.cx>; Fri, 2 Oct 2009 09:02:28 +0200 (CEST)(nullmailer pid 15081 invoked by uid 51645);
Fri, 02 Oct 2009 07:02:28 -0000sysadmin@kde.orgFri, 02 Oct 2009 07:02:28 +0000<1254466948.024750.15080.nullmailer@svn.kde.org>KDEapps1030302sstjamestrunk/KDE/kdebase/apps/keditbookmarks/bookmarklistview.cpptrunk/KDE/kdebase/apps/keditbookmarks/bookmarkmodel.cppCheck for invalid index in bookmarkForIndex(...) (prevents another crash).
Prevent non-folder items being drop targets (courtesy of dfaure).
Deal better with inserting before/ after items in both folder and normal views.
CCBUG:1606791561254466959Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id E7EEF1D821F
for <cia@cia.navi.cx>; Sat, 29 Aug 2009 01:13:51 -0700 (PDT)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id 901C8177
for <cia@cia.navi.cx>; Sat, 29 Aug 2009 10:13:41 +0200 (CEST)(nullmailer pid 14866 invoked by uid 51645);
Sat, 29 Aug 2009 08:13:41 -0000sysadmin@kde.orgSat, 29 Aug 2009 08:13:41 +0000<1251533621.558342.14865.nullmailer@svn.kde.org>KDEkio1016872sstjamestrunk/KDE/kdelibs/kio/bookmarks/kbookmark.ccOnly non-cloneNode()'d QDomElements are notified when their containing QDomDocument is destroyed, so taking cloneNode()'d elements that will outlive their QDomDocument leads to dangling pointers! Don't do this :)
This appears to fix at least one of the crashes in 160679 but I'm sure unrelated ones remain.
CCBUG:160679141251533632Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 956801D80DF
for <cia@cia.navi.cx>; Fri, 15 May 2009 11:26:24 -0700 (PDT)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id 1185D1B4
for <cia@cia.navi.cx>; Fri, 15 May 2009 20:26:14 +0200 (CEST)(nullmailer pid 26719 invoked by uid 51645);
Fri, 15 May 2009 18:26:14 -0000sysadmin@kde.orgFri, 15 May 2009 18:26:14 +0000<1242411974.521260.26718.nullmailer@svn.kde.org>KDEworkspace968441sstjamestrunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.cppThere seems to be some difficulty with specifying KConfig::Global when we are already using kdeglobals, in that it never writes out the settings, so do what the icons kcm does and use KGlobal::config() - as dfaure points out, this has the advantage of being more efficient, anyway. This is related to the following bugs (iconText and iconSize have much the same root causes), which I am also currently trying to fix:
CCBUG:168480
CCBUG:169067381242411985Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 897B01D80C1
for <cia@cia.navi.cx>; Sun, 1 Feb 2009 14:06:53 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id 25DF1173
for <cia@cia.navi.cx>; Sun, 1 Feb 2009 23:06:44 +0100 (CET)(nullmailer pid 8040 invoked by uid 51645);
Sun, 01 Feb 2009 22:06:44 -0000sysadmin@kde.orgSun, 01 Feb 2009 22:06:44 +0000<1233526004.123663.8039.nullmailer@svn.kde.org>KDEapps919951sstjamesbranches/KDE/4.2/kdebase/apps/dolphin/src/folderexpander.cppBackport r919950: Hovering over blank space in a view while dragging would trigger the FolderExpander on the folder represented by the view, which we don't want. Detect and prevent it.
CCBUG:182618161233526013Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id A209B1D80C1
for <cia@cia.navi.cx>; Sun, 1 Feb 2009 14:03:30 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id 8B725122
for <cia@cia.navi.cx>; Sun, 1 Feb 2009 23:03:20 +0100 (CET)(nullmailer pid 7866 invoked by uid 51645);
Sun, 01 Feb 2009 22:03:20 -0000sysadmin@kde.orgSun, 01 Feb 2009 22:03:20 +0000<1233525800.461148.7865.nullmailer@svn.kde.org>KDEapps919950sstjamestrunk/KDE/kdebase/apps/dolphin/src/folderexpander.cppHovering over blank space in a view while dragging would trigger the FolderExpander on the folder represented by the view, which we don't want. Detect and prevent it.
BUG:182618
Shipped! ;)161233525810Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id E1F221D80D1
for <cia@cia.navi.cx>; Tue, 27 Jan 2009 11:50:43 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id 6C3E63D0
for <cia@cia.navi.cx>; Tue, 27 Jan 2009 20:50:34 +0100 (CET)(nullmailer pid 9299 invoked by uid 51645);
Tue, 27 Jan 2009 19:50:34 -0000sysadmin@kde.orgTue, 27 Jan 2009 19:50:33 +0000<1233085833.846268.9291.nullmailer@svn.kde.org>KDEapps917389sstjamestrunk/KDE/kdebase/apps/dolphin/src/CMakeLists.txttrunk/KDE/kdebase/apps/dolphin/src/panels/information/informationpanel.cpptrunk/KDE/kdebase/apps/dolphin/src/panels/information/informationpanel.htrunk/KDE/kdebase/apps/dolphin/src/panels/information/phononwidget.cpptrunk/KDE/kdebase/apps/dolphin/src/panels/information/phononwidget.hInitial import of Matthias's draft patch for adding video and audio previewing (similar to the file dialog) to Dolphin's metadata panel. Since Phonon is currently in-process only with the memory/ stability issues that come with this, this might have to be disabled by default - we'll see how it goes. Thanks, Matthias!
CCMAIL:kretz@kde.org
CCMAIL:peter.penz@gmx.at2511233085844Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 98B171C00DD
for <cia@cia.navi.cx>; Sun, 25 Jan 2009 11:46:19 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id 13C9118E
for <cia@cia.navi.cx>; Sun, 25 Jan 2009 20:46:10 +0100 (CET)(nullmailer pid 30953 invoked by uid 51645);
Sun, 25 Jan 2009 19:46:10 -0000sysadmin@kde.orgSun, 25 Jan 2009 19:46:10 +0000<1232912770.049584.30952.nullmailer@svn.kde.org>KDEapps916701sstjamestrunk/KDE/kdebase/apps/dolphin/src/dolphincolumnview.cpptrunk/KDE/kdebase/apps/dolphin/src/dolphincolumnview.htrunk/KDE/kdebase/apps/dolphin/src/dolphincontroller.cpptrunk/KDE/kdebase/apps/dolphin/src/dolphincontroller.htrunk/KDE/kdebase/apps/dolphin/src/dolphinview.cpptrunk/KDE/kdebase/apps/dolphin/src/dolphinview.htrunk/KDE/kdebase/apps/dolphin/src/draganddrophelper.cpptrunk/KDE/kdebase/apps/dolphin/src/draganddrophelper.htrunk/KDE/kdebase/apps/dolphin/src/folderexpander.cpptrunk/KDE/kdebase/apps/dolphin/src/folderexpander.hRefactor the folder expansion system. Main effect: instead of having a list of m_expandedViews which cannot yet be deleted, we more accurately identify the current source of the drag operation if any and store only this for later deletion.
This also fixes folder-expansion not working in Column view.3751232912780Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 3C6051D80D1
for <cia@cia.navi.cx>; Fri, 23 Jan 2009 10:59:45 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id 73DB81A1
for <cia@cia.navi.cx>; Fri, 23 Jan 2009 19:59:34 +0100 (CET)(nullmailer pid 2038 invoked by uid 51645);
Fri, 23 Jan 2009 18:59:34 -0000sysadmin@kde.orgFri, 23 Jan 2009 18:59:34 +0000<1232737174.440766.2037.nullmailer@svn.kde.org>KDEapps915785sstjamesbranches/KDE/4.2/kdebase/apps/dolphin/src/dolphindetailsview.cppBackport r915781: In rare circumstances (a very narrow viewport is a necessary, but not sufficient, condition) DolphinDetailsView::resizeColumns() is called with an empty model so that sizeHintForColumn(...) returns -1 and so the name column ultimately has width -1. Detect and prevent this.141232737187Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 2AA901D80D1
for <cia@cia.navi.cx>; Fri, 23 Jan 2009 10:55:19 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id 9BD1D1A1
for <cia@cia.navi.cx>; Fri, 23 Jan 2009 19:55:09 +0100 (CET)(nullmailer pid 1543 invoked by uid 51645);
Fri, 23 Jan 2009 18:55:09 -0000sysadmin@kde.orgFri, 23 Jan 2009 18:55:09 +0000<1232736909.598297.1542.nullmailer@svn.kde.org>KDEapps915781sstjamestrunk/KDE/kdebase/apps/dolphin/src/dolphindetailsview.cppIn rare circumstances (a very narrow viewport is a necessary, but not sufficient, condition) DolphinDetailsView::resizeColumns() is called with an empty model so that sizeHintForColumn(...) returns -1 and so the name column ultimately has width -1. Detect and prevent this.141232736919Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 029CF1D80D1
for <cia@cia.navi.cx>; Wed, 21 Jan 2009 11:43:56 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id A49EC196
for <cia@cia.navi.cx>; Wed, 21 Jan 2009 20:43:46 +0100 (CET)(nullmailer pid 18117 invoked by uid 51645);
Wed, 21 Jan 2009 19:43:46 -0000sysadmin@kde.orgWed, 21 Jan 2009 19:43:46 +0000<1232567026.591034.18112.nullmailer@svn.kde.org>KDEapps914799sstjamestrunk/KDE/kdebase/apps/dolphin/src/dolphinview.cppTwo KFilePreviewGenerator's operating on the same KDirModel can lead to infinite loops of preview generation. If view is not delete'd (e.g. as a result of a FolderExpander), then m_previewGenerator won't be either: delete it manually to prevent having two active at once. 221232567036Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 930241D80BA
for <cia@cia.navi.cx>; Mon, 19 Jan 2009 11:18:39 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id 7810870
for <cia@cia.navi.cx>; Mon, 19 Jan 2009 20:18:29 +0100 (CET)(nullmailer pid 26563 invoked by uid 51645);
Mon, 19 Jan 2009 19:18:29 -0000sysadmin@kde.orgMon, 19 Jan 2009 19:18:29 +0000<1232392709.437150.26561.nullmailer@svn.kde.org>KDEapps913720sstjamesbranches/KDE/4.2/kdebase/apps/dolphin/src/dolphinpart.cppBackport of r913713: Update the KPart host's status bar info when selection changes.161232392720Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 0B35E1D80BA
for <cia@cia.navi.cx>; Mon, 19 Jan 2009 11:11:50 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id 7917A74
for <cia@cia.navi.cx>; Mon, 19 Jan 2009 20:11:40 +0100 (CET)(nullmailer pid 23630 invoked by uid 51645);
Mon, 19 Jan 2009 19:11:40 -0000sysadmin@kde.orgMon, 19 Jan 2009 19:11:40 +0000<1232392300.463662.23629.nullmailer@svn.kde.org>KDEapps913713sstjamestrunk/KDE/kdebase/apps/dolphin/src/dolphinpart.cppUpdate the KPart host's status bar info when selection changes.161232392310Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 9AE9E1D80B2
for <cia@cia.navi.cx>; Wed, 7 Jan 2009 10:23:49 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id AF63E17E
for <cia@cia.navi.cx>; Wed, 7 Jan 2009 19:23:39 +0100 (CET)(nullmailer pid 14096 invoked by uid 51645);
Wed, 07 Jan 2009 18:23:39 -0000sysadmin@kde.orgWed, 07 Jan 2009 18:23:39 +0000<1231352619.577713.14095.nullmailer@svn.kde.org>KDEkio907250sstjamestrunk/KDE/kdelibs/kio/kio/kdirwatch.cpptrunk/KDE/kdelibs/kio/kio/kdirwatch_p.hMake proper use of inotify's implicit "WatchFiles" ability. Immediate effect: Dolphin etc should now report changes to file attributes, rather than just creations and deletions, when KDirWatch uses inotify as its backend. Secondary effect: Assuming no bugs, we should consume at most the same number of inotify watches as before (and often much less).
Approved by Flavio Castelli.
CCMAIL:1546761711231352631Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 678DB1D80A0
for <cia@cia.navi.cx>; Sat, 3 Jan 2009 08:00:55 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id A65676C
for <cia@cia.navi.cx>; Sat, 3 Jan 2009 17:00:44 +0100 (CET)(nullmailer pid 10724 invoked by uid 51645);
Sat, 03 Jan 2009 16:00:41 -0000sysadmin@kde.orgSat, 03 Jan 2009 16:00:41 +0000<1230998441.543543.10722.nullmailer@svn.kde.org>KDEapps904995sstjamestrunk/KDE/kdebase/apps/dolphin/src/dolphindetailsview.cpptrunk/KDE/kdebase/apps/dolphin/src/dolphindetailsview.hcontentsPos turned out to be a little broken - it would always return (0,0), except in a very unusual set of circumstances where it returned ... "different" values, causing very odd behaviour with the elastic band :) Remove it.781230998456Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 3A532180368
for <cia@cia.navi.cx>; Mon, 29 Dec 2008 03:12:38 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id ACBFD17A
for <cia@cia.navi.cx>; Mon, 29 Dec 2008 12:12:27 +0100 (CET)(nullmailer pid 28111 invoked by uid 51645);
Mon, 29 Dec 2008 11:12:27 -0000sysadmin@kde.orgMon, 29 Dec 2008 11:12:27 +0000<1230549147.675771.28110.nullmailer@svn.kde.org>KDEworkspace902827sstjamestrunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clock.htrunk/KDE/kdebase/workspace/plasma/applets/calendar/calendar.htrunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.hRespond to r902778 to unbreak kdebase for anyone doing a fresh checkout. 421230549159Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id AD5AA1D8084
for <cia@cia.navi.cx>; Sun, 28 Dec 2008 10:58:56 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id B129190
for <cia@cia.navi.cx>; Sun, 28 Dec 2008 19:58:45 +0100 (CET)(nullmailer pid 32109 invoked by uid 51645);
Sun, 28 Dec 2008 18:58:45 -0000sysadmin@kde.orgSun, 28 Dec 2008 18:58:45 +0000<1230490725.685061.32108.nullmailer@svn.kde.org>KDEapps902594sstjamestrunk/KDE/kdebase/apps/keditbookmarks/bookmarkinfo.cppUpdate the text in the Location KLineEdit only when the actual URL it represents conflicts with that of the current bookmark, not when the textual representations of the URLs differ.
BUG:172647301230490737Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 591891D80A2
for <cia@cia.navi.cx>; Wed, 10 Dec 2008 14:54:16 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id C9AAA185
for <cia@cia.navi.cx>; Wed, 10 Dec 2008 23:54:05 +0100 (CET)(nullmailer pid 19849 invoked by uid 51645);
Wed, 10 Dec 2008 22:54:05 -0000sysadmin@kde.orgWed, 10 Dec 2008 22:54:05 +0000<1228949645.790996.19848.nullmailer@svn.kde.org>KDEkio895536sstjamestrunk/KDE/kdelibs/kio/kfile/kicondialog.cppMagic numbers--, pad icons to respect uniformItemSizes, choose appropriate size to reduce need for padding and ensure SVGs are scaled to a matching size, add delegate so that more space is allocated for text, increase grid (thus, text) size and initial dialog size.
BUG:1727462011228949656Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id 26C0D1D807C
for <cia@cia.navi.cx>; Tue, 9 Dec 2008 04:47:51 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id 78832182
for <cia@cia.navi.cx>; Tue, 9 Dec 2008 13:47:40 +0100 (CET)(nullmailer pid 29869 invoked by uid 51645);
Tue, 09 Dec 2008 12:47:40 -0000sysadmin@kde.orgTue, 09 Dec 2008 12:47:40 +0000<1228826860.461586.29868.nullmailer@svn.kde.org>KDEplasma894855sstjamestrunk/playground/base/plasma/wallpapers/marble/marble.cppIf the globe is non-rotating, no updates are performed - even if we are tracking the night/ day shadow. Fix this. [First Plasma Patch!]141228826871Subversion CIA Bot client shell script1.0from office.kde.org (kde.suse.de [195.135.221.67])
by cia.vc (Postfix) with ESMTP id B3F361D8209
for <cia@cia.navi.cx>; Wed, 5 Nov 2008 13:54:17 -0800 (PST)from svn.kde.org (localhost [127.0.0.1])
by office.kde.org (Postfix) with SMTP id 97B7674
for <cia@cia.navi.cx>; Wed, 5 Nov 2008 22:54:06 +0100 (CET)(nullmailer pid 18100 invoked by uid 51645);
Wed, 05 Nov 2008 21:54:06 -0000sysadmin@kde.orgWed, 05 Nov 2008 21:54:06 +0000<1225922046.590346.18099.nullmailer@svn.kde.org>KDEapps880585sstjamestrunk/KDE/kdebase/apps/dolphin/src/dolphindetailsview.cppIf the elastic band ventures beyond the logical top-left of the view (NOTE: not the viewport), then startIndex will likely be invalid, resulting in broken selection behaviour. Prevent this.
CCMAIL: peter.penz@gmx.at191225922073