zherczeg@webkit.org

Heap-buffer-overflow in WebCore::CSSParser::lex...

Fri, 10 Feb 2012 11:14:42 +0000

Commit by zherczeg@webkit.org :: r107369 /trunk/ (5 files in 4 dirs):

Heap-buffer-overflow in WebCore::CSSParser::lex
https://bugs.webkit.org/show_bug.cgi?id=77402

Reviewed by Antti Koivisto.

Source/WebCore:

Comments should check only a single \0 terminator.

Test: fast/css/parsing-css-comment.html

css/CSSParser.cpp: (WebCore::CSSParser::lex): LayoutTests: Test various comment types.
fast/css/parsing-css-comment-expected.txt: Added.
fast/css/parsing-css-comment.html: Added.

Custom written CSS lexer https://bugs.webkit.org/show_bug.cgi?id=70107 Rubber...

Mon, 30 Jan 2012 14:36:54 +0000

Commit by zherczeg@webkit.org :: r106227 Source/WebCore/ (ChangeLog css/CSSParser.cpp):

Custom written CSS lexer
https://bugs.webkit.org/show_bug.cgi?id=70107

Rubber Stamped by Csaba Osztrogonác.

Do not advance pointer at the end of input, just
keep returning with END_TOKEN.

css/CSSParser.cpp: (WebCore::CSSParser::lex):

Custom written CSS lexer https://bugs.webkit.org/show_bug.cgi?id=70107 Reviewed...

Mon, 30 Jan 2012 10:49:05 +0000

Commit by zherczeg@webkit.org :: r106217 /trunk/ (18 files in 9 dirs):

Custom written CSS lexer
https://bugs.webkit.org/show_bug.cgi?id=70107

Reviewed by Antti Koivisto and Oliver Hunt.

.:

Remove tokenizer.cpp from intermediate sources.

wscript: Source/JavaScriptCore: Add new helper functions for the custom written CSS lexer.
wtf/ASCIICType.h: (WTF::toASCIILowerUnchecked): (WTF): (WTF::isASCIIAlphaCaselessEqual): Source/WebCore: This patch replaces the flex based CSS lexer to a new, custom written one. The new code is more than 2 times faster according to oprofile and CPU cycle counters. The code structure is quite straightforward: it choose the possible token group based on the first character and employ utility functions to parse the longer than one character long ones. Most of the utilities are inline to make the lexer fast. All build systems updated. Including removing the flex support. Existing tests cover this feature.
CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.am:
GNUmakefile.list.am:
WebCore.gyp/WebCore.gyp:
WebCore.gyp/scripts/action_maketokenizer.py: Removed.
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::setupParser): (WebCore::parseSimpleLengthValue): (WebCore::mightBeRGBA): (WebCore::mightBeRGB): (): (WebCore::isCSSLetter): (WebCore): (WebCore::isCSSEscape): (WebCore::isURILetter): (WebCore::isIdentifierStartAfterDash): (WebCore::isEqualToCSSIdentifier): (WebCore::checkAndSkipEscape): (WebCore::skipWhiteSpace): (WebCore::CSSParser::isIdentifierStart): (WebCore::CSSParser::checkAndSkipString): (WebCore::CSSParser::parseEscape): (WebCore::CSSParser::parseIdentifier): (WebCore::CSSParser::parseString): (WebCore::CSSParser::parseURI): (WebCore::CSSParser::parseUnicodeRange): (WebCore::CSSParser::parseNthChild): (WebCore::CSSParser::parseNthChildExtra): (WebCore::CSSParser::detectFunctionTypeToken): (WebCore::CSSParser::detectMediaQueryToken): (WebCore::CSSParser::detectNumberToken): (WebCore::CSSParser::detectDashToken): (WebCore::CSSParser::detectAtToken): (WebCore::CSSParser::lex): (WebCore::CSSParser::markSelectorListStart): (WebCore::CSSParser::markSelectorListEnd): (WebCore::CSSParser::markRuleBodyStart): (WebCore::CSSParser::markRuleBodyEnd): (WebCore::CSSParser::markPropertyStart): (WebCore::CSSParser::markPropertyEnd):
css/CSSParser.h: (WebCore::CSSParser::token): (CSSParser): ():
css/tokenizer.flex: Removed.

Fix turbulence bug when stitch tiles enabled and rendered in parallel...

Thu, 12 Jan 2012 18:06:06 +0000

Commit by zherczeg@webkit.org :: r104824 /trunk/ (8 files in 5 dirs):

Fix turbulence bug when stitch tiles enabled and rendered in parallel
https://bugs.webkit.org/show_bug.cgi?id=76042

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The width / height / wrap members are used by all threads
in the same time. The patch makes them local for all threads.

Fixes the layout fails in svg/dynamic-updates/SVGFETurbulence*

platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::noise2D): (WebCore::Noise::if): (WebCore::FETurbulence::calculateTurbulenceValueForPoint): (WebCore::FETurbulence::fillRegion):
platform/graphics/filters/FETurbulence.h: (WebCore::FETurbulence::PaintingData::PaintingData): (WebCore::FETurbulence::StitchData::StitchData): LayoutTests: Update mac expected files.
platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:

Fix more style errors in CSSParser.cpp (followup patch)...

Wed, 11 Jan 2012 13:19:52 +0000

Commit by zherczeg@webkit.org :: r104688 Source/WebCore/ (ChangeLog css/CSSParser.cpp):

Fix more style errors in CSSParser.cpp (followup patch)
https://bugs.webkit.org/show_bug.cgi?id=76038

Reviewed by Nikolas Zimmermann.

The previous was: http://trac.webkit.org/changeset/104576
This patch mostly contains C cast to static_cast rewrites.

css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundColor): (WebCore::ShadowParseContext::commitLength): (WebCore::BorderImageSliceParseContext::commitNumber): (WebCore::BorderImageSliceParseContext::commitBorderImageSlice): (WebCore::BorderImageQuadParseContext::commitNumber): (WebCore::BorderImageQuadParseContext::commitBorderImageQuad): (WebCore::parseDeprecatedGradientPoint):

Fix style errors in CSSParser.cpp https://bugs.webkit.org/show_bug.cgi?id=75854...

Tue, 10 Jan 2012 19:06:06 +0000

Commit by zherczeg@webkit.org :: r104576 Source/WebCore/ (ChangeLog css/CSSParser.cpp):

Fix style errors in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=75854

Reviewed by Nikolas Zimmermann.

Minor style fixes.

css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseShadow): (WebCore::isBorderImageRepeatKeyword): (WebCore::BorderImageSliceParseContext::commitBorderImageSlice): (WebCore::BorderImageQuadParseContext::commitBorderImageQuad): (WebCore::filterInfoForName):

Unreviewed gardening after r104134. * wtf/Assertions.cpp:

Thu, 05 Jan 2012 14:28:56 +0000

Commit by zherczeg@webkit.org :: r104135 Source/JavaScriptCore/ (ChangeLog wtf/Assertions.cpp):

Unreviewed gardening after r104134.

wtf/Assertions.cpp:

Unreviewed gardening after r75605. Rubber stamped by NOBODY Csaba Osztrogonác. *...

Thu, 05 Jan 2012 14:11:09 +0000

Commit by zherczeg@webkit.org :: r104134 Source/JavaScriptCore/ (ChangeLog wtf/Assertions.cpp):

Unreviewed gardening after r75605.

Rubber stamped by NOBODY Csaba Osztrogonác.

wtf/Assertions.cpp:

Unreviewed, Qt rebaseline after r102149 and r102846. *...

Thu, 15 Dec 2011 12:22:33 +0000

Commit by zherczeg@webkit.org :: r102904 LayoutTests/ (4 files in 3 dirs):

Unreviewed, Qt rebaseline after r102149 and r102846.

platform/qt/editing/pasteboard/paste-text-013-expected.txt:
platform/qt/editing/pasteboard/paste-text-014-expected.txt:
platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.

Add new CSS nth-children parsing tests...

Mon, 12 Dec 2011 10:34:57 +0000

Commit by zherczeg@webkit.org :: r102560 /trunk/ (5 files in 4 dirs):

Add new CSS nth-children parsing tests
https://bugs.webkit.org/show_bug.cgi?id=74178

Source/WebCore:

Reviewed by Darin Adler.

Test: fast/css/parsing-css-nth-child.html

css/CSSParser.cpp: (WebCore::isValidNthToken): Add "-n" to the possible identifiers. LayoutTests: The test covers several valid and invalid nth-child tokens. Reviewed by Darin Adler.
fast/css/parsing-css-nth-child-expected.txt: Added.
fast/css/parsing-css-nth-child.html: Added.

Unreviewed gardening. * fast/harness/results-expected.txt: Update after r99818.

Thu, 10 Nov 2011 12:36:43 +0000

Commit by zherczeg@webkit.org :: r99828 LayoutTests/ (2 files in 2 dirs):

Unreviewed gardening.

fast/harness/results-expected.txt: Update after r99818.

Optimizing arithmetic composite filter to ARM-neon SIMD instruction set...

Thu, 03 Nov 2011 16:17:03 +0000

Commit by zherczeg@webkit.org :: r99183 Source/WebCore/ (10 files in 4 dirs):

Optimizing arithmetic composite filter to ARM-neon SIMD instruction set
https://bugs.webkit.org/show_bug.cgi?id=65522

Reviewed by Dirk Schulze.

This patch continues the work of Felician Marton.

The arithmetic operation of feComposite SVG filter can be greatly enhanced
by the ARM-NEON instruction set since we are able to calculate the pixel data
for all four RGBA channels at the same time.

It won't affect the general behavior and existing tests will cover the changes.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
platform/graphics/filters/FEComposite.cpp: (WebCore::computeArithmeticPixels): (WebCore::arithmeticSoftware): (WebCore::FEComposite::platformArithmeticSoftware): (WebCore::FEComposite::platformApplySoftware):
platform/graphics/filters/FEComposite.h:
platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp: Added.
platform/graphics/filters/arm/FECompositeArithmeticNEON.h: Added. (WebCore::FEComposite::platformArithmeticNeon):

Match allowed CSS string characters to Firefox and Opera browsers...

Wed, 02 Nov 2011 21:21:34 +0000

Commit by zherczeg@webkit.org :: r99086 /trunk/ (5 files in 4 dirs):

Match allowed CSS string characters to Firefox and Opera browsers
https://bugs.webkit.org/show_bug.cgi?id=71000

Reviewed by Darin Adler.

Source/WebCore:

Firefox and Opera accepts any character inside a string except
newline and starting quote character. This behaviour matches to
the CSS 2.1 grammar: http://www.w3.org/TR/CSS2/grammar.html
WebKit should follow them.

Test: fast/css/parsing-css-allowed-string-characters.html

css/tokenizer.flex: LayoutTests: Add a new test case which contains various uncommon characters.
fast/css/parsing-css-allowed-string-characters-expected.txt: Added.
fast/css/parsing-css-allowed-string-characters.html: Added.

Testing allowed identifier chars which are greater than 126...

Fri, 28 Oct 2011 21:05:49 +0000

Commit by zherczeg@webkit.org :: r98744 LayoutTests/ (3 files in 2 dirs):

Testing allowed identifier chars which are greater than 126
https://bugs.webkit.org/show_bug.cgi?id=71097

Reviewed by Darin Adler.

fast/css/parsing-css-nonascii-expected.txt: Added.
fast/css/parsing-css-nonascii.html: Added.

Add new CSS escape sequence parsing tests...

Wed, 26 Oct 2011 20:54:26 +0000

Commit by zherczeg@webkit.org :: r98504 LayoutTests/ (3 files in 2 dirs):

Add new CSS escape sequence parsing tests
https://bugs.webkit.org/show_bug.cgi?id=70909

Reviewed by Darin Adler.

Test escape various sequences terminated by \n \f \r and \r\n.

fast/css/parsing-css-escapes-expected.txt: Added.
fast/css/parsing-css-escapes.html: Added.

Add new uri tokenizer tests https://bugs.webkit.org/show_bug.cgi?id=70807...

Tue, 25 Oct 2011 20:46:51 +0000

Commit by zherczeg@webkit.org :: r98366 LayoutTests/ (3 files in 2 dirs):

Add new uri tokenizer tests
https://bugs.webkit.org/show_bug.cgi?id=70807

Reviewed by Darin Adler.

Test more cases!

fast/css/uri-token-parsing-expected.txt:
fast/css/uri-token-parsing.html:

Improve NEON based GaussianBlur https://bugs.webkit.org/show_bug.cgi?id=70493...

Thu, 20 Oct 2011 15:25:03 +0000

Commit by zherczeg@webkit.org :: r97970 Source/WebCore/ (2 files in 2 dirs):

Improve NEON based GaussianBlur
https://bugs.webkit.org/show_bug.cgi?id=70493

Reviewed by Csaba Osztrogonác.

vmov instruction is less complex than vtbl.

platform/graphics/filters/arm/FEGaussianBlurNEON.cpp:

Unreviewed, Qt rebaseline after r96789. *...

Thu, 06 Oct 2011 11:42:08 +0000

Commit by zherczeg@webkit.org :: r96795 LayoutTests/ (5 files in 2 dirs):

Unreviewed, Qt rebaseline after r96789.

platform/qt/http/tests/navigation/postredirect-basic-expected.txt:
platform/qt/http/tests/navigation/postredirect-frames-expected.txt: Added.
platform/qt/http/tests/navigation/postredirect-goback1-expected.txt:
platform/qt/http/tests/navigation/postredirect-goback2-expected.txt: Added.

[Qt]REGRESSION(r95912): It made sputnik tests flakey...

Mon, 03 Oct 2011 08:59:50 +0000

Commit by zherczeg@webkit.org :: r96483 Source/JavaScriptCore/ (ChangeLog runtime/Structure.h):

[Qt]REGRESSION(r95912): It made sputnik tests flakey
https://bugs.webkit.org/show_bug.cgi?id=68990

Reviewed by Geoffrey Garen.

Changing signed char to int in r96354 solved the
problem. However transitionCount still returns
with a signed char and should be changed to int.

runtime/Structure.h: (JSC::Structure::transitionCount):

[Qt] Unreviewed gardening. Adding new test expectations. *...

Thu, 15 Sep 2011 10:37:39 +0000

Commit by zherczeg@webkit.org :: r95179 LayoutTests/ (5 files in 3 dirs):

[Qt] Unreviewed gardening. Adding new test expectations.

platform/qt/fast/borders/border-image-massive-scale-expected.txt: Added.
platform/qt/fast/borders/border-image-scaled-gradient-expected.txt: Added.
platform/qt/fast/borders/border-image-scrambled-expected.txt: Added.
platform/qt/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.