http://cia.vc/stats/author/zherczeg%40webkit.org86711Python Subversion client for CIA1.18WebKit107369zherczeg@webkit.orgHeap-buffer-overflow in WebCore::CSSParser::lex https://bugs.webkit.org/show_bug.cgi?id=77402 Reviewed by Antti Koivisto. Source/WebCore: Comments should check only a single \0 terminator. Test: fast/css/parsing-css-comment.html * css/CSSParser.cpp: (WebCore::CSSParser::lex): LayoutTests: Test various comment types. * fast/css/parsing-css-comment-expected.txt: Added. * fast/css/parsing-css-comment.html: Added. 168trunk/LayoutTests/ChangeLogtrunk/LayoutTests/fast/css/parsing-css-comment-expected.txttrunk/LayoutTests/fast/css/parsing-css-comment.htmltrunk/Source/WebCore/ChangeLogtrunk/Source/WebCore/css/CSSParser.cpp1328872482Python Subversion client for CIA1.18WebKitSource106227zherczeg@webkit.orgCustom written CSS lexer https://bugs.webkit.org/show_bug.cgi?id=70107 Rubber Stamped by Csaba Osztrogonác. Do not advance pointer at the end of input, just keep returning with END_TOKEN. * css/CSSParser.cpp: (WebCore::CSSParser::lex): 57WebCore/ChangeLogWebCore/css/CSSParser.cpp1327934214Python Subversion client for CIA1.18WebKit106217zherczeg@webkit.orgCustom written CSS lexer https://bugs.webkit.org/show_bug.cgi?id=70107 Reviewed by Antti Koivisto and Oliver Hunt. .: Remove tokenizer.cpp from intermediate sources. * wscript: Source/JavaScriptCore: Add new helper functions for the custom written CSS lexer. * wtf/ASCIICType.h: (WTF::toASCIILowerUnchecked): (WTF): (WTF::isASCIIAlphaCaselessEqual): Source/WebCore: This patch replaces the flex based CSS lexer to a new, custom written one. The new code is more than 2 times faster according to oprofile and CPU cycle counters. The code structure is quite straightforward: it choose the possible token group based on the first character and employ utility functions to parse the longer than one character long ones. Most of the utilities are inline to make the lexer fast. All build systems updated. Including removing the flex support. Existing tests cover this feature. * CMakeLists.txt: * DerivedSources.make: * DerivedSources.pri: * GNUmakefile.am: * GNUmakefile.list.am: * WebCore.gyp/WebCore.gyp: * WebCore.gyp/scripts/action_maketokenizer.py: Removed. * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::setupParser): (WebCore::parseSimpleLengthValue): (WebCore::mightBeRGBA): (WebCore::mightBeRGB): (): (WebCore::isCSSLetter): (WebCore): (WebCore::isCSSEscape): (WebCore::isURILetter): (WebCore::isIdentifierStartAfterDash): (WebCore::isEqualToCSSIdentifier): (WebCore::checkAndSkipEscape): (WebCore::skipWhiteSpace): (WebCore::CSSParser::isIdentifierStart): (WebCore::CSSParser::checkAndSkipString): (WebCore::CSSParser::parseEscape): (WebCore::CSSParser::parseIdentifier): (WebCore::CSSParser::parseString): (WebCore::CSSParser::parseURI): (WebCore::CSSParser::parseUnicodeRange): (WebCore::CSSParser::parseNthChild): (WebCore::CSSParser::parseNthChildExtra): (WebCore::CSSParser::detectFunctionTypeToken): (WebCore::CSSParser::detectMediaQueryToken): (WebCore::CSSParser::detectNumberToken): (WebCore::CSSParser::detectDashToken): (WebCore::CSSParser::detectAtToken): (WebCore::CSSParser::lex): (WebCore::CSSParser::markSelectorListStart): (WebCore::CSSParser::markSelectorListEnd): (WebCore::CSSParser::markRuleBodyStart): (WebCore::CSSParser::markRuleBodyEnd): (WebCore::CSSParser::markPropertyStart): (WebCore::CSSParser::markPropertyEnd): * css/CSSParser.h: (WebCore::CSSParser::token): (CSSParser): (): * css/tokenizer.flex: Removed. 2294trunk/ChangeLogtrunk/Source/JavaScriptCore/ChangeLogtrunk/Source/JavaScriptCore/wtf/ASCIICType.htrunk/Source/WebCore/CMakeLists.txttrunk/Source/WebCore/ChangeLogtrunk/Source/WebCore/DerivedSources.maketrunk/Source/WebCore/DerivedSources.pritrunk/Source/WebCore/GNUmakefile.amtrunk/Source/WebCore/GNUmakefile.list.amtrunk/Source/WebCore/WebCore.gyp/WebCore.gyptrunk/Source/WebCore/WebCore.gyp/scripts/action_maketokenizer.pytrunk/Source/WebCore/WebCore.gypitrunk/Source/WebCore/WebCore.vcproj/WebCore.vcprojtrunk/Source/WebCore/WebCore.xcodeproj/project.pbxprojtrunk/Source/WebCore/css/CSSParser.cpptrunk/Source/WebCore/css/CSSParser.htrunk/Source/WebCore/css/tokenizer.flextrunk/wscript1327920545Python Subversion client for CIA1.18WebKit104824zherczeg@webkit.orgFix turbulence bug when stitch tiles enabled and rendered in parallel https://bugs.webkit.org/show_bug.cgi?id=76042 Reviewed by Nikolas Zimmermann. Source/WebCore: The width / height / wrap members are used by all threads in the same time. The patch makes them local for all threads. Fixes the layout fails in svg/dynamic-updates/SVGFETurbulence* * platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::noise2D): (WebCore::Noise::if): (WebCore::FETurbulence::calculateTurbulenceValueForPoint): (WebCore::FETurbulence::fillRegion): * platform/graphics/filters/FETurbulence.h: (WebCore::FETurbulence::PaintingData::PaintingData): (WebCore::FETurbulence::StitchData::StitchData): LayoutTests: Update mac expected files. * platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: * platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: 271trunk/LayoutTests/ChangeLogtrunk/LayoutTests/platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.pngtrunk/LayoutTests/platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.pngtrunk/LayoutTests/platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.pngtrunk/LayoutTests/platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.pngtrunk/Source/WebCore/ChangeLogtrunk/Source/WebCore/platform/graphics/filters/FETurbulence.cpptrunk/Source/WebCore/platform/graphics/filters/FETurbulence.h1326391566Python Subversion client for CIA1.18WebKitSource104688zherczeg@webkit.orgFix more style errors in CSSParser.cpp (followup patch) https://bugs.webkit.org/show_bug.cgi?id=76038 Reviewed by Nikolas Zimmermann. The previous was: http://trac.webkit.org/changeset/104576 This patch mostly contains C cast to static_cast rewrites. * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundColor): (WebCore::ShadowParseContext::commitLength): (WebCore::BorderImageSliceParseContext::commitNumber): (WebCore::BorderImageSliceParseContext::commitBorderImageSlice): (WebCore::BorderImageQuadParseContext::commitNumber): (WebCore::BorderImageQuadParseContext::commitBorderImageQuad): (WebCore::parseDeprecatedGradientPoint): 135WebCore/ChangeLogWebCore/css/CSSParser.cpp1326287992Python Subversion client for CIA1.18WebKitSource104576zherczeg@webkit.orgFix style errors in CSSParser.cpp https://bugs.webkit.org/show_bug.cgi?id=75854 Reviewed by Nikolas Zimmermann. Minor style fixes. * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseShadow): (WebCore::isBorderImageRepeatKeyword): (WebCore::BorderImageSliceParseContext::commitBorderImageSlice): (WebCore::BorderImageQuadParseContext::commitBorderImageQuad): (WebCore::filterInfoForName): 183WebCore/ChangeLogWebCore/css/CSSParser.cpp1326222366Python Subversion client for CIA1.18WebKitSource104135zherczeg@webkit.orgUnreviewed gardening after r104134. * wtf/Assertions.cpp: 41JavaScriptCore/ChangeLogJavaScriptCore/wtf/Assertions.cpp1325773736Python Subversion client for CIA1.18WebKitSource104134zherczeg@webkit.orgUnreviewed gardening after r75605. Rubber stamped by NOBODY Csaba Osztrogonác. * wtf/Assertions.cpp: 41JavaScriptCore/ChangeLogJavaScriptCore/wtf/Assertions.cpp1325772669Python Subversion client for CIA1.18WebKitLayoutTests102904zherczeg@webkit.orgUnreviewed, Qt rebaseline after r102149 and r102846. * platform/qt/editing/pasteboard/paste-text-013-expected.txt: * platform/qt/editing/pasteboard/paste-text-014-expected.txt: * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added. 341ChangeLogplatform/qt/editing/pasteboard/paste-text-013-expected.txtplatform/qt/editing/pasteboard/paste-text-014-expected.txtplatform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt1323951753Python Subversion client for CIA1.18WebKit102560zherczeg@webkit.orgAdd new CSS nth-children parsing tests https://bugs.webkit.org/show_bug.cgi?id=74178 Source/WebCore: Reviewed by Darin Adler. Test: fast/css/parsing-css-nth-child.html * css/CSSParser.cpp: (WebCore::isValidNthToken): Add "-n" to the possible identifiers. LayoutTests: The test covers several valid and invalid nth-child tokens. Reviewed by Darin Adler. * fast/css/parsing-css-nth-child-expected.txt: Added. * fast/css/parsing-css-nth-child.html: Added. 225trunk/LayoutTests/ChangeLogtrunk/LayoutTests/fast/css/parsing-css-nth-child-expected.txttrunk/LayoutTests/fast/css/parsing-css-nth-child.htmltrunk/Source/WebCore/ChangeLogtrunk/Source/WebCore/css/CSSParser.cpp1323686097Python Subversion client for CIA1.18WebKitLayoutTests99828zherczeg@webkit.orgUnreviewed gardening. * fast/harness/results-expected.txt: Update after r99818. 144ChangeLogfast/harness/results-expected.txt1320928603Python Subversion client for CIA1.18WebKitSource99183zherczeg@webkit.orgOptimizing arithmetic composite filter to ARM-neon SIMD instruction set https://bugs.webkit.org/show_bug.cgi?id=65522 Reviewed by Dirk Schulze. This patch continues the work of Felician Marton. The arithmetic operation of feComposite SVG filter can be greatly enhanced by the ARM-NEON instruction set since we are able to calculate the pixel data for all four RGBA channels at the same time. It won't affect the general behavior and existing tests will cover the changes. * CMakeLists.txt: * GNUmakefile.list.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * platform/graphics/filters/FEComposite.cpp: (WebCore::computeArithmeticPixels): (WebCore::arithmeticSoftware): (WebCore::FEComposite::platformArithmeticSoftware): (WebCore::FEComposite::platformApplySoftware): * platform/graphics/filters/FEComposite.h: * platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp: Added. * platform/graphics/filters/arm/FECompositeArithmeticNEON.h: Added. (WebCore::FEComposite::platformArithmeticNeon): 434WebCore/CMakeLists.txtWebCore/ChangeLogWebCore/GNUmakefile.list.amWebCore/WebCore.gypiWebCore/WebCore.proWebCore/WebCore.vcproj/WebCore.vcprojWebCore/platform/graphics/filters/FEComposite.cppWebCore/platform/graphics/filters/FEComposite.hWebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.cppWebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h1320337023Python Subversion client for CIA1.18WebKit99086zherczeg@webkit.orgMatch allowed CSS string characters to Firefox and Opera browsers https://bugs.webkit.org/show_bug.cgi?id=71000 Reviewed by Darin Adler. Source/WebCore: Firefox and Opera accepts any character inside a string except newline and starting quote character. This behaviour matches to the CSS 2.1 grammar: http://www.w3.org/TR/CSS2/grammar.html WebKit should follow them. Test: fast/css/parsing-css-allowed-string-characters.html * css/tokenizer.flex: LayoutTests: Add a new test case which contains various uncommon characters. * fast/css/parsing-css-allowed-string-characters-expected.txt: Added. * fast/css/parsing-css-allowed-string-characters.html: Added. 204trunk/LayoutTests/ChangeLogtrunk/LayoutTests/fast/css/parsing-css-allowed-string-characters-expected.txttrunk/LayoutTests/fast/css/parsing-css-allowed-string-characters.htmltrunk/Source/WebCore/ChangeLogtrunk/Source/WebCore/css/tokenizer.flex1320268894Python Subversion client for CIA1.18WebKitLayoutTests98744zherczeg@webkit.orgTesting allowed identifier chars which are greater than 126 https://bugs.webkit.org/show_bug.cgi?id=71097 Reviewed by Darin Adler. * fast/css/parsing-css-nonascii-expected.txt: Added. * fast/css/parsing-css-nonascii.html: Added. 140ChangeLogfast/css/parsing-css-nonascii-expected.txtfast/css/parsing-css-nonascii.html1319835949Python Subversion client for CIA1.18WebKitLayoutTests98504zherczeg@webkit.orgAdd new CSS escape sequence parsing tests https://bugs.webkit.org/show_bug.cgi?id=70909 Reviewed by Darin Adler. Test escape various sequences terminated by \n \f \r and \r\n. * fast/css/parsing-css-escapes-expected.txt: Added. * fast/css/parsing-css-escapes.html: Added. 121ChangeLogfast/css/parsing-css-escapes-expected.txtfast/css/parsing-css-escapes.html1319662466Python Subversion client for CIA1.18WebKitLayoutTests98366zherczeg@webkit.orgAdd new uri tokenizer tests https://bugs.webkit.org/show_bug.cgi?id=70807 Reviewed by Darin Adler. Test more cases! * fast/css/uri-token-parsing-expected.txt: * fast/css/uri-token-parsing.html: 71ChangeLogfast/css/uri-token-parsing-expected.txtfast/css/uri-token-parsing.html1319575611Python Subversion client for CIA1.18WebKitSource97970zherczeg@webkit.orgImprove NEON based GaussianBlur https://bugs.webkit.org/show_bug.cgi?id=70493 Reviewed by Csaba Osztrogonác. vmov instruction is less complex than vtbl. * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: 88WebCore/ChangeLogWebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.cpp1319124303Python Subversion client for CIA1.18WebKitLayoutTests96795zherczeg@webkit.orgUnreviewed, Qt rebaseline after r96789. * platform/qt/http/tests/navigation/postredirect-basic-expected.txt: * platform/qt/http/tests/navigation/postredirect-frames-expected.txt: Added. * platform/qt/http/tests/navigation/postredirect-goback1-expected.txt: * platform/qt/http/tests/navigation/postredirect-goback2-expected.txt: Added. 123ChangeLogplatform/qt/http/tests/navigation/postredirect-basic-expected.txtplatform/qt/http/tests/navigation/postredirect-frames-expected.txtplatform/qt/http/tests/navigation/postredirect-goback1-expected.txtplatform/qt/http/tests/navigation/postredirect-goback2-expected.txt1317901328Python Subversion client for CIA1.18WebKitSource96483zherczeg@webkit.org[Qt]REGRESSION(r95912): It made sputnik tests flakey https://bugs.webkit.org/show_bug.cgi?id=68990 Reviewed by Geoffrey Garen. Changing signed char to int in r96354 solved the problem. However transitionCount still returns with a signed char and should be changed to int. * runtime/Structure.h: (JSC::Structure::transitionCount): 38JavaScriptCore/ChangeLogJavaScriptCore/runtime/Structure.h1317632390Python Subversion client for CIA1.18WebKitLayoutTests95179zherczeg@webkit.org[Qt] Unreviewed gardening. Adding new test expectations. * platform/qt/fast/borders/border-image-massive-scale-expected.txt: Added. * platform/qt/fast/borders/border-image-scaled-gradient-expected.txt: Added. * platform/qt/fast/borders/border-image-scrambled-expected.txt: Added. * platform/qt/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added. 94ChangeLogplatform/qt/fast/borders/border-image-massive-scale-expected.txtplatform/qt/fast/borders/border-image-scaled-gradient-expected.txtplatform/qt/fast/borders/border-image-scrambled-expected.txtplatform/qt/fast/parser/innerhtml-with-prefixed-elements-expected.txt1316083059