Ecore

scim_immodule: improve maintenability

Mon, 13 Feb 2012 14:22:20 +0000

Commit by jihoon :: r67878 ecore/src/modules/immodules/scim/scim_imcontext.cpp: (link)

scim_immodule: improve maintenability

From: 윤정현 Subject: Re: [E-devel] [Patch] ecore_ipc -...

Mon, 13 Feb 2012 10:16:21 +0000

Commit by raster :: r67874 ecore/src/lib/ecore_ipc/ecore_ipc.c: (link)

From: 윤정현 <jh0506 dot yun at samsung dot com>
Subject: Re: [E-devel] [Patch] ecore_ipc - remove potential risk in
ecore_ipc_shutdown

I found a problem this infinite loop case.

If server is deleted, then ECORE_IPC_EVENT_SERVER_DEL callback
function will be called in client side.
It will happen infinite loop in ecore_ipc_shutdown if
ecore_ipc_shutdown called in this ECORE_IPC_EVENT_SERVER_DEL callback
function.

For example,
server_del_handler =
ecore_event_handler_add(ECORE_IPC_EVENT_SERVER_DEL, _server_del_cb, NULL);
static Eina_Bool
_server_del_cb(void *data, int type, void *event)
{
   ecore_ipc_shutdown();
   return EINA_TRUE;
 }

If server is deleted,
1. _ecore_ipc_event_server_del : svr->event_count++
2. _server_del_cb : ecore_ipc_shutdown called
3. ecore_ipc_shutdown : while (servers) ecore_ipc_server_del(eina_list_data_get(servers))
4. ecore_ipc_server_del : can't eina_list_remove(servers, svr) because event_count != 0
5. infinite loop

I think this while code is very dangerous whether user miss or not.
I modified EINA_LIST_FOREACH_SAFE instead of EINA_LIST_FOREACH refer
to ecore_con.
Please review this patch.

scim_immodule: set cursor location even though only client_window is provided...

Sun, 12 Feb 2012 14:27:08 +0000

Commit by jihoon :: r67852 ecore/src/modules/immodules/scim/scim_imcontext.cpp: (link)

scim_immodule: set cursor location even though only client_window is provided without evas (ecore_imf_context_client_canvas_set)

Ecore_Evas_Cocoa: fix header include name.

Fri, 10 Feb 2012 16:52:59 +0000

Commit by rfonseca :: r67825 ecore/src/lib/ecore_evas/ecore_evas_cocoa.c: (link)

Ecore_Evas_Cocoa: fix header include name.

Ecore: Add ChangeLog entries for new ecore_evas_wayland function.

Fri, 10 Feb 2012 14:02:37 +0000

Commit by devilhorns :: r67820 ecore/ChangeLog: (link)

Ecore: Add ChangeLog entries for new ecore_evas_wayland function.

Ecore_Evas (wayland): Disable logfn's (again) :( Remove extra parens.

Fri, 10 Feb 2012 14:01:30 +0000

Commit by devilhorns :: r67819 ecore/src/lib/ecore_evas/ (2 files): (link)

Ecore_Evas (wayland): Disable logfn's (again) :( Remove extra parens.

Ecore_Evas: Add functions for setting wayland mouse pointer (used from elm...

Fri, 10 Feb 2012 12:41:39 +0000

Commit by devilhorns :: r67816 ecore/src/lib/ecore_evas/ (5 files): (link)

Ecore_Evas: Add functions for setting wayland mouse pointer (used from
elm wayland clients).

scim_immmodule: Provide compose, string in key down/up event in case of...

Fri, 10 Feb 2012 03:28:20 +0000

Commit by jihoon :: r67801 ecore/ (2 files in 2 dirs): (link)

scim_immmodule: Provide compose, string in key down/up event in case of scim-input-pad.

Ecore_Wl: Add function in header.

Thu, 09 Feb 2012 11:41:19 +0000

Commit by devilhorns :: r67782 ecore/src/lib/ecore_wayland/Ecore_Wayland.h: (link)

Ecore_Wl: Add function in header.

Ecore_Wl: Also send mouse move before sending mouse down/up. Add some missing...

Thu, 09 Feb 2012 11:39:43 +0000

Commit by devilhorns :: r67781 ecore/src/lib/ecore_wayland/ecore_wl.c: (link)

Ecore_Wl: Also send mouse move before sending mouse down/up. Add some
missing Logfn's. Add handler to free the mouse_move event when we're
done with it. Add a function to retrieve the 'last mouse button down
time' (needed for fixing surface move).

Ecore_Evas (Wayland): Fix getting double mouse events for the wayland engines....

Thu, 09 Feb 2012 11:37:11 +0000

Commit by devilhorns :: r67780 ecore/src/lib/ecore_evas/ (2 files): (link)

Ecore_Evas (Wayland): Fix getting double mouse events for the wayland
engines.

NB: Fixes elementary momentum scrolling.

ecore_imf_context.c: fix formatting

Thu, 09 Feb 2012 07:17:29 +0000

Commit by jihoon :: r67779 ecore/src/lib/ecore_imf/ecore_imf_context.c: (link)

ecore_imf_context.c: fix formatting

add new curl function to news

Thu, 09 Feb 2012 04:14:59 +0000

Commit by discomfitor :: r67777 ecore/NEWS: (link)

add new curl function to news

@since from @67759

Thu, 09 Feb 2012 02:22:26 +0000

Commit by discomfitor :: r67774 ecore/src/lib/ecore_con/Ecore_Con.h: (link)

@since from @67759

fix compile without curl from @67759, also add missing magic check SPANK SPANK...

Thu, 09 Feb 2012 00:50:02 +0000

Commit by discomfitor :: r67772 ecore/src/lib/ecore_con/ecore_con_url.c: (link)

fix compile without curl from @67759, also add missing magic check
SPANK SPANK SPANK RASTER

Ecore tests: Disable ecore_x tests in the meanwhile. They are currently useless...

Wed, 08 Feb 2012 20:14:14 +0000

Commit by tasn :: r67768 ecore/src/tests/ecore_test_ecore_x.c: (link)

Ecore tests: Disable ecore_x tests in the meanwhile.

They are currently useless and just cause buildbot to complain.

add ecore_con_url_http_version_set() to be able to specify request version

Wed, 08 Feb 2012 16:49:14 +0000

Commit by raster :: r67759 ecore/ (3 files in 2 dirs): (link)

add ecore_con_url_http_version_set() to be able to specify request
version

Support ecore_imf_context_input_panel_show/hide in SCIM module

Tue, 07 Feb 2012 13:54:24 +0000

Commit by jihoon :: r67728 ecore/ (4 files in 2 dirs): (link)

Support ecore_imf_context_input_panel_show/hide in SCIM module

ecore_imf_xim: Support ecore_imf_context_input_panel_show/hide in XIM module.

Tue, 07 Feb 2012 13:33:49 +0000

Commit by jihoon :: r67727 ecore/ (2 files in 2 dirs): (link)

ecore_imf_xim: Support ecore_imf_context_input_panel_show/hide in XIM module.

Ecore_IMF.h: fix wrong documentation about Ecore_IMF_Preedit_Attr

Tue, 07 Feb 2012 05:53:51 +0000

Commit by jihoon :: r67723 ecore/src/lib/ecore_imf/Ecore_IMF.h: (link)

Ecore_IMF.h: fix wrong documentation about Ecore_IMF_Preedit_Attr