http://cia.vc/stats/project/kde/amarok177146420811NoneRediscover your music!NoneAmarokhttp://amarok.kde.orgNoneKDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id EFF762E727
for <cia@cia.vc>; Mon, 13 Feb 2012 19:16:41 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id E62CEA6096
for <cia@cia.vc>; Tue, 14 Feb 2012 00:49:23 +0100 (CET)sysadmin@kde.org<20120213234923.E62CEA6096@git.kde.org>Tue, 14 Feb 2012 00:49:23 +0100 (CET)KDEamarokmaster1329176679Matěj Laitlv2.5.0-124-g0b979bbChangeLogsrc/browsers/playlistbrowser/PlaylistBrowserModel.cppsrc/core/playlists/Playlist.hsrc/playlistmanager/sql/SqlPlaylist.cppAlways use nonnegative position in Playlist::notifyObserversTrackAdded()
This was the cause of bug 293295. Thanks to Marius for spotting and
reporting it.
BUGFIXES:
* Don't misbehave when track is dropped directly to saved playlist.
BUG: 293295
FIXED-IN: 2.6http://commits.kde.org/amarok/0b979bb9c0daf3a0832d966efbc1993d777fdcecKDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id CA71C2E722
for <cia@cia.vc>; Sat, 11 Feb 2012 14:49:55 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id 94F2CA6096
for <cia@cia.vc>; Sat, 11 Feb 2012 20:23:58 +0100 (CET)sysadmin@kde.org<20120211192358.94F2CA6096@git.kde.org>Sat, 11 Feb 2012 20:23:58 +0100 (CET)KDEamarokmaster1328988202Matěj Laitlv2.5.0-123-gec41a52READMEAdd gmock optional dependency to READMEhttp://commits.kde.org/amarok/ec41a526e1234b172c72801ba0e7dcb51e0f440fKDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id AFBA82E722
for <cia@cia.vc>; Wed, 8 Feb 2012 16:59:14 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id 763A8A60A6
for <cia@cia.vc>; Wed, 8 Feb 2012 22:34:57 +0100 (CET)sysadmin@kde.org<20120208213457.763A8A60A6@git.kde.org>Wed, 8 Feb 2012 22:34:57 +0100 (CET)KDEamarokmaster1328736738Bart Cerneelsv2.5.0-121-gd564521src/EngineController.cppFix playing CD's broken in recent commit.
commit 67f5c1ae332f6727f91af346a6b5858fe6e5b285 introduced percent encoding,
which was not properly decoded in EngineController.
CCMAIL:b.steinbrink@gmx.dehttp://commits.kde.org/amarok/d564521c9f2c95525aa6f38fc7075b3712826f34KDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id 819242E722
for <cia@cia.vc>; Tue, 7 Feb 2012 07:34:36 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id 95D02A60B9
for <cia@cia.vc>; Tue, 7 Feb 2012 13:10:59 +0100 (CET)sysadmin@kde.org<20120207121059.95D02A60B9@git.kde.org>Tue, 7 Feb 2012 13:10:59 +0100 (CET)KDEamarokmaster1328615555Matěj Laitlv2.5.0-118-ga8332c4ChangeLogsrc/core-impl/collections/umscollection/UmsCollection.cppsrc/core-impl/meta/file/File.cppsrc/core-impl/meta/file/File.hsrc/core-impl/meta/file/File_p.hMetaFile::Track: add setCollection(), use it in UmsCollection
BUGFIXES:
* Don't report collection of USB Mass Storage tracks as None.
DIGEST: Bugfixhttp://commits.kde.org/amarok/a8332c4e6c3e8aa17fe46c8aadc7e91ff8868c01KDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id 4098D2E722
for <cia@cia.vc>; Tue, 7 Feb 2012 07:34:34 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id 8039EA6096
for <cia@cia.vc>; Tue, 7 Feb 2012 13:10:59 +0100 (CET)sysadmin@kde.org<20120207121059.8039EA6096@git.kde.org>Tue, 7 Feb 2012 13:10:59 +0100 (CET)KDEamarokmaster1328268235Matěj Laitlv2.5.0-117-g8a90627ChangeLogsrc/browsers/CollectionTreeItemModel.cppsrc/browsers/CollectionTreeItemModelBase.cppsrc/browsers/CollectionTreeItemModelBase.hsrc/browsers/CollectionTreeView.cppsrc/browsers/CollectionTreeView.hAnother approach to fix bug 291068, be more permissive
Bart originally solved the bug by enabling track dropping only
precisely on root collection rows. This is IMO too much restrictive
as it prevents you to drag tracks between 2 large expanded collections
without excessive scrolling. (something I would miss) Additionally,
there was no visual indication that the drop will not be performed.
This is my try to rework it in a way that:
* keeps drops onto artists/albums (whatever you first level
entity in collection browser is) allowed. There is a drop indicator
that clearly shows that the drop will go _between_ the entities, not
to them.
* disables drops to read-only collections
* disabled drops are indicated visually using the not-allowed mouse
cursor (the tricky part, but commented well in code)
Some more code comments not present in review request are added.
BUG: 291068
REVIEW: 103856
DIGEST: More natural drag'n'drop behaviour in collection browserhttp://commits.kde.org/amarok/8a90627d3f25363ff9795b72b414c9c8c0498dbaKDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id 1FA1F2E722
for <cia@cia.vc>; Sun, 5 Feb 2012 18:41:19 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id 7DB86A6096
for <cia@cia.vc>; Mon, 6 Feb 2012 00:18:42 +0100 (CET)sysadmin@kde.org<20120205231842.7DB86A6096@git.kde.org>Mon, 6 Feb 2012 00:18:42 +0100 (CET)KDEamarokmaster1328483711Matěj Laitlv2.5.0-116-g88f7be6src/context/applets/videoclip/VideoclipApplet.cppFix another crash on exit with Qt 4.8 wrt qDeleteAll()
BUG: 285951http://commits.kde.org/amarok/88f7be636917cdf060b0b6de62a5701161727185KDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id 9BA322E722
for <cia@cia.vc>; Sun, 5 Feb 2012 17:39:59 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id 7EE63A6096
for <cia@cia.vc>; Sun, 5 Feb 2012 23:17:24 +0100 (CET)sysadmin@kde.org<20120205221724.7EE63A6096@git.kde.org>Sun, 5 Feb 2012 23:17:24 +0100 (CET)KDEamarokmaster1328479941Matěj Laitlv2.5.0-115-g1140d30src/core-impl/collections/support/MemoryCollection.hOlder gcc evidently needs template parameters repeated
Some users got these errors with gcc 4.4.5:
src/core-impl/collections/support/MemoryCollection.h:38:
Error: "template<class Key, class T> class QMap" used without template
parameters
Thanks to d-fens_ in #amarokhttp://commits.kde.org/amarok/1140d3056af65ddf0f3999df846f1fd44970c303KDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id 6D69F2E723
for <cia@cia.vc>; Sun, 5 Feb 2012 16:38:12 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id C23BCA60B9
for <cia@cia.vc>; Sun, 5 Feb 2012 22:15:38 +0100 (CET)sysadmin@kde.org<20120205211538.C23BCA60B9@git.kde.org>Sun, 5 Feb 2012 22:15:38 +0100 (CET)KDEamarokmaster1328474533Matěj Laitlv2.5.0-114-g76239bbChangeLogsrc/core-impl/collections/umscollection/UmsCollection.cppsrc/core-impl/collections/umscollection/UmsCollection.hUmsCollection: rework factory <-> collection interaction
The main change is that the UmsCollection is created only for
_accessible_ (mounted) Solid devices so no phantom (allowing no
interaction) collections are listed in collection browser.
Another change is that not-activated UMS collections get
"(not activated)" appended to their name so that it is more clear that
users need to click "Use As Collection" button, which is by the way
renamed to "Activate This Collection" by this commit.
The changes in UmsColllectionFactory are done with future merge with
other "new" pluggable collections factories in mind -- 80% of the code
in UmsColllecionFactory is the same as in out-of-tree rewrite of the
iPod collection.
CHANGES:
* Don't show unmounted USB Mass Storage devices and make it clear when
the device is not "activated" yet.
CCMAIL: Bart Cerneels <bart.cerneels@kde.org>
DIGEST: Better behaviour of USB Mass Storage collection [see CHANGES]http://commits.kde.org/amarok/76239bb9d70930b3cc6a5313ae96edfd58c39868KDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id 603A62E722
for <cia@cia.vc>; Sun, 5 Feb 2012 16:38:12 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id BA29DA6096
for <cia@cia.vc>; Sun, 5 Feb 2012 22:15:38 +0100 (CET)sysadmin@kde.org<20120205211538.BA29DA6096@git.kde.org>Sun, 5 Feb 2012 22:15:38 +0100 (CET)KDEamarokmaster1328475678Matěj Laitlv2.5.0-113-g3e0935csrc/core-impl/collections/db/sql/device/massstorage/amarok_device_massstorage.desktopFixup previous commit, Local Files backend supports pluggable devices too
CCBUG: 293277http://commits.kde.org/amarok/3e0935ccdb5a13ca415655d9c9e45166db5ccfbfKDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id BD5172E722
for <cia@cia.vc>; Sun, 5 Feb 2012 12:55:27 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id 6F805A6096
for <cia@cia.vc>; Sun, 5 Feb 2012 18:32:59 +0100 (CET)sysadmin@kde.org<20120205173259.6F805A6096@git.kde.org>Sun, 5 Feb 2012 18:32:59 +0100 (CET)KDEamarokmaster1328440247Matěj Laitlv2.5.0-112-g3788b0eChangeLogsrc/configdialog/ConfigDialog.cppsrc/configdialog/dialogs/PluginsConfig.cppsrc/core-impl/collections/db/sql/device/massstorage/amarok_device_massstorage.desktopsrc/core-impl/collections/db/sql/device/nfs/amarok_device_nfs.desktopsrc/core-impl/collections/db/sql/device/smb/amarok_device_smb.desktopChange GUI strings in Configuration dialog to reduce user confusion
This is a result of a dialogue with an Amarok user (Leonidas Tsampros)
on #amarok who (logically) thought that if he enables "NFS Device" in
"Devices" section of Amarok plugins, NFS will pop-up as another
collection.
This is not how SMB, NFS, MassStorage "Devices" work currently, they
are meant to enable users to have a part of their collection on
respective devices.
I believe that the old plugin names and descriptions are confusing to
the extent that their translations should be dropped; it should be a
plenty of time till Amarok 2.6 so translators should have opportunity
to pickup these. (or, do .desktop translations get erased automatically
when original string changes?)
CHANGES:
* "Devices" in Amarok configuration -> Plugins is with other related strings
renamed to "Local Collection Backends" to reduce user confusion.
BUG: 293277
FIXED-IN: 2.6
REVIEW: 103871http://commits.kde.org/amarok/3788b0ee6d6407c1b459b16181d32db247aedcafKDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id 83FA82E722
for <cia@cia.vc>; Sat, 4 Feb 2012 07:12:32 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id BF543A6096
for <cia@cia.vc>; Sat, 4 Feb 2012 12:50:46 +0100 (CET)sysadmin@kde.org<20120204115046.BF543A6096@git.kde.org>Sat, 4 Feb 2012 12:50:46 +0100 (CET)KDEamarokmaster1328355965Matěj Laitlv2.5.0-111-gccd18a6ChangeLogsrc/core-impl/meta/file/File_p.hMetaFile::Album: support for embedded album cover reading & writing
FEATURES:
* Support for embedded album covers in non-collection tracks and
in USB Mass Storage collection.
This could potentially slow down performace of album loading, but my
tests show that cover art loading takes 2 - 10ms, which is really okay.
Also, the fact that track has embedded cover is cached, so there is no
penalty for tracks wihout cover.
DIGEST: Featurehttp://commits.kde.org/amarok/ccd18a6cbc2ff10231768191534d98efc4cca8ecKDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id AF9D12E722
for <cia@cia.vc>; Fri, 3 Feb 2012 20:04:45 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id 7AE27A6096
for <cia@cia.vc>; Sat, 4 Feb 2012 01:43:10 +0100 (CET)sysadmin@kde.org<20120204004310.7AE27A6096@git.kde.org>Sat, 4 Feb 2012 01:43:10 +0100 (CET)KDEamarokmaster1328303780Matěj Laitlv2.5.0-108-g2267541ChangeLogsrc/core-impl/collections/umscollection/UmsCollectionLocation.cppsrc/core-impl/collections/umscollection/UmsCollectionLocation.hUmsCollectionLocation: cleanups, corrections, fixes
This fixes UmsCollectionLocation to be on par with Amarok standards.
This is the first part of making the USB Mass Storage collection behave
like it should.
BUGFIXES:
* Remove empty folders when deleting tracks from USB Mass Storage collection.
* Don't copy tracks to USB Mass Storage collection in move operation.
* Fix defunct aborting of transfers to USB Mass Storage collection.
BUG: 290448
FIXED-IN: 2.6
DIGEST: bugfix
CCMAIL: Bart Cerneels <bart.cerneels@kde.org>http://commits.kde.org/amarok/226754158de9385df12cb17adaac198c4c3807cdKDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id B1A922E726
for <cia@cia.vc>; Fri, 3 Feb 2012 20:04:45 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id 8803BA60B9
for <cia@cia.vc>; Sat, 4 Feb 2012 01:43:10 +0100 (CET)sysadmin@kde.org<20120204004310.8803BA60B9@git.kde.org>Sat, 4 Feb 2012 01:43:10 +0100 (CET)KDEamarokmaster1328314046Matěj Laitlv2.5.0-109-gc31d00fChangeLogsrc/core-impl/collections/umscollection/UmsCollection.cppsrc/core-impl/collections/umscollection/UmsCollection.hsrc/core-impl/collections/umscollection/UmsCollectionLocation.cppsrc/core-impl/collections/umscollection/UmsCollectionLocation.hUmsCollection: reflect track add/change/remove in the ui
I wonder no-one actually noticed/reported that the collection browser
doesn't update.
BUGFIXES:
* When adding, changing and removing tracks in USB Mass Storage collection,
actually update the user interface to show it.
DIGEST: bugfix
CCMAIL: Bart Cerneels <bart.cerneels@kde.org>http://commits.kde.org/amarok/c31d00f08f4d6e003c6206553988ddd1b3b9fdc1KDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id B0AB52E723
for <cia@cia.vc>; Fri, 3 Feb 2012 20:04:45 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id 8F90CA60BE
for <cia@cia.vc>; Sat, 4 Feb 2012 01:43:10 +0100 (CET)sysadmin@kde.org<20120204004310.8F90CA60BE@git.kde.org>Sat, 4 Feb 2012 01:43:10 +0100 (CET)KDEamarokmaster1328315673Matěj Laitlv2.5.0-110-g0292de0src/core-impl/collections/support/CollectionManager.cppExtend fix of bug 285951 to the other crash site
This should definitely fix the Amarok crashes during exit bug.
BUG: 285951
FIXED-IN: 2.6
DIGEST: fix crash bughttp://commits.kde.org/amarok/0292de05bf5ae2cf161fc8cdaecf4effab4fc34bKDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id 3DDAC2E722
for <cia@cia.vc>; Fri, 3 Feb 2012 07:00:41 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id 8B383A6096
for <cia@cia.vc>; Fri, 3 Feb 2012 12:39:29 +0100 (CET)sysadmin@kde.org<20120203113929.8B383A6096@git.kde.org>Fri, 3 Feb 2012 12:39:29 +0100 (CET)KDEamarokmaster1328215633Matěj Laitlv2.5.0-107-ge9f05d8ChangeLogsrc/browsers/CollectionTreeItemModel.cppsrc/browsers/CollectionTreeItemModel.hsrc/browsers/CollectionTreeView.cppsrc/browsers/CollectionTreeView.hShift key while dragging tracks to collections changes from copying to moving
The functionality was already there, but unintentionally disabled because
default implementation of CollectionTreeItemModel::supportedDropActions()
did not return Qt::MoveAction.
Care is taken to visually indicate the feature in gui by changing the mouse
cursor.
DIGEST: Feature, see title.http://commits.kde.org/amarok/e9f05d82e64f2a3165470c4b7195ea91c9e46823KDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id 0E7512E721
for <cia@cia.vc>; Thu, 2 Feb 2012 05:08:06 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id CCC41A6096
for <cia@cia.vc>; Thu, 2 Feb 2012 10:47:31 +0100 (CET)sysadmin@kde.org<20120202094731.CCC41A6096@git.kde.org>Thu, 2 Feb 2012 10:47:31 +0100 (CET)KDEamarokmaster1328175450Björn Steinbrinkv2.5.0-106-g67f5c1aChangeLogsrc/core-impl/collections/audiocd/AudioCdCollection.cppFix failure to rip CD tracks with special characters in their title
Certain characters such as ? have a special meaning in URLs so they have
to be encoded when used in path component, but the AudioCdCollection
fails to do so and just embeds the raw track title into the URL. Thus it
is impossible to rip tracks that contain such characters in their title,
as the URL passed to the KIO subsystem is invalid.
BUG: 224437
FIXED-IN: 2.6
REVIEW: 103841http://commits.kde.org/amarok/67f5c1ae332f6727f91af346a6b5858fe6e5b285KDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id 2936B2E723
for <cia@cia.vc>; Wed, 1 Feb 2012 02:27:00 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id AE85CA6096
for <cia@cia.vc>; Wed, 1 Feb 2012 08:07:03 +0100 (CET)sysadmin@kde.org<20120201070703.AE85CA6096@git.kde.org>Wed, 1 Feb 2012 08:07:03 +0100 (CET)KDEamarokmaster1328010974Bart Cerneelsv2.5.0-103-geae396eChangeLogsrc/browsers/playlistbrowser/PlaylistBrowserView.cppsrc/browsers/playlistbrowser/PlaylistBrowserView.hEnable keyboard activation of PlaylistBrowser items.
Note: keyboard navigation using the arrow keys is only possible if the
default shortcut asssignments for seeking are changed.http://commits.kde.org/amarok/eae396ee97469fa3e2940b5e7c62e6e58e502539KDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id 24B902E722
for <cia@cia.vc>; Wed, 1 Feb 2012 02:27:00 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id BD53FA60A9
for <cia@cia.vc>; Wed, 1 Feb 2012 08:07:03 +0100 (CET)sysadmin@kde.org<20120201070703.BD53FA60A9@git.kde.org>Wed, 1 Feb 2012 08:07:03 +0100 (CET)KDEamarokmaster1328012142Bart Cerneelsv2.5.0-104-g73813afChangeLogsrc/browsers/playlistbrowser/PlaylistBrowserView.cppsrc/browsers/playlistbrowser/PlaylistBrowserView.hFix PlaylistBrowser scroll w/ keyboard navigation.
BUG: 259791
FIXED-IN: 2.6http://commits.kde.org/amarok/73813af33c61f0a7f67060f4d0264c1825996867KDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id 229002E721
for <cia@cia.vc>; Wed, 1 Feb 2012 02:27:00 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id C2E73A60BE
for <cia@cia.vc>; Wed, 1 Feb 2012 08:07:03 +0100 (CET)sysadmin@kde.org<20120201070703.C2E73A60BE@git.kde.org>Wed, 1 Feb 2012 08:07:03 +0100 (CET)KDEamarokmaster1328013674Bart Cerneelsv2.5.0-105-g8d103cfChangeLogsrc/browsers/CollectionTreeItemModel.cppDon't accept drops on non-collectionheader items.
Caused the copy dialog to come up.
BUG: 291068
FIXED-IN: 2.6http://commits.kde.org/amarok/8d103cf35705690d17f8f9437618868e2cbb98b3KDE CIA Python client1.00http://projects.kde.org/repo-managementfrom git.kde.org (git.kde.org [195.135.221.71])
by cia.vc (Postfix) with ESMTP id B9BE62E721
for <cia@cia.vc>; Tue, 31 Jan 2012 16:35:45 -0800 (PST)from git.kde.org (localhost [IPv6:::1])
by git.kde.org (Postfix) with ESMTP id B86E7A6096
for <cia@cia.vc>; Tue, 31 Jan 2012 22:16:03 +0100 (CET)sysadmin@kde.org<20120131211603.B86E7A6096@git.kde.org>Tue, 31 Jan 2012 22:16:03 +0100 (CET)KDEamarokmaster1328044243Daniel Faustv2.5.0-102-gcd76b2cChangeLogsrc/dialogs/EqualizerDialog.cppFix crash when trying to save custom equalizer presets.
This also improves the UI a little bit (deactivates unusable buttons).
Also it prohibits saving a 'Manual' profile in non-english versions.
Overwriting default presets still doesn't work in non-english versions, though.
BUG:286227
FIXED-IN:2.6http://commits.kde.org/amarok/cd76b2ccd50f0c83dadd295022ba37b683473619