WebKit

Chrome crashes when attempting to add cue to track element...

Tue, 14 Feb 2012 03:33:39 +0000

Commit by commit-queue@webkit.org :: r107632 /trunk/ (6 files in 4 dirs):

Chrome crashes when attempting to add cue to track element
https://bugs.webkit.org/show_bug.cgi?id=77951

Patch by Arun Patole <bmf834 at motorola dot com> on 2012-02-13
Reviewed by Eric Carlson.

Source/WebCore:

Allocate text track's text track list of cues before using it.

html/TextTrack.cpp: (WebCore::TextTrack::cues): (WebCore::TextTrack::addCue): (WebCore::TextTrack::removeCue): return if text track list of cues is not allocated. (WebCore::TextTrack::ensureTextTrackCueList):Added.
html/TextTrack.h: (TextTrack): LayoutTests: Updated add-remove-cue.html to handle adding a new cue to the text track created with addTextTrack.
media/track/track-add-remove-cue-expected.txt:
media/track/track-add-remove-cue.html:

Rollout 105763.

Tue, 14 Feb 2012 03:24:14 +0000

Commit by lforschler@apple.com on safari-534.54-branch :: r107631 /Source/WebKit2/ (ChangeLog UIProcess/win/WebView.cpp):

Rollout 105763.

Fix font-face-weight-matching.html and font-face-synthetic-bold-italic.html...

Tue, 14 Feb 2012 03:23:08 +0000

Commit by bashi@chromium.org :: r107630 LayoutTests/ (3 files in 2 dirs):

Fix font-face-weight-matching.html and font-face-synthetic-bold-italic.html
https://bugs.webkit.org/show_bug.cgi?id=78492

Fix the URL of Ahem.ttf.

Reviewed by Eric Seidel.

fast/css/font-face-synthetic-bold-italic.html:
fast/css/font-face-weight-matching.html:

Fix the Windows build. * platform/PlatformPasteboard.h: (PlatformPasteboard):

Tue, 14 Feb 2012 03:21:17 +0000

Commit by aestes@apple.com :: r107629 Source/WebCore/ (ChangeLog platform/PlatformPasteboard.h):

Fix the Windows build.

platform/PlatformPasteboard.h: (PlatformPasteboard):

Merged r107496.

Tue, 14 Feb 2012 03:21:10 +0000

Commit by lforschler@apple.com on safari-534.54-branch :: r107628 / (6 files in 5 dirs):

Merged r107496.

Crash with button in multi-column layout....

Tue, 14 Feb 2012 03:14:01 +0000

Commit by inferno@chromium.org :: r107627 /trunk/ (5 files in 4 dirs):

Crash with button in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78378

Reviewed by David Hyatt.

Source/WebCore:

Button creates an anonymous wrapper and expects that new children
be added to its m_inner anonymous block. However, splitBlock code
incorrectly creates column blocks directly under the button.

Test: fast/multicol/span/split-flow-anonymous-wrapper-crash.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::containingColumnsBlock): (WebCore::RenderBlock::columnsBlockForSpanningElement): LayoutTests:
fast/multicol/span/split-flow-anonymous-wrapper-crash-expected.txt: Added.
fast/multicol/span/split-flow-anonymous-wrapper-crash.html: Added.

Fix the Windows build. * WebCoreSupport/WebPlatformStrategies.cpp:...

Tue, 14 Feb 2012 03:06:39 +0000

Commit by aestes@apple.com :: r107626 Source/WebKit/win/ (3 files in 2 dirs):

Fix the Windows build.

WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::createPasteboardStrategy):
WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies):

Replace old strtod with new strtod https://bugs.webkit.org/show_bug.cgi?id=68044...

Tue, 14 Feb 2012 03:05:56 +0000

Commit by mhahnenberg@apple.com :: r107625 Source/JavaScriptCore/ (7 files in 5 dirs):

Replace old strtod with new strtod
https://bugs.webkit.org/show_bug.cgi?id=68044

Reviewed by Geoffrey Garen.

parser/Lexer.cpp: Added template argument. This version allows junk after numbers. (JSC::::lex):
runtime/JSGlobalObjectFunctions.cpp: Ditto. (JSC::parseInt): (JSC::jsStrDecimalLiteral):
runtime/LiteralParser.cpp: Ditto. (JSC::::Lexer::lexNumber):
wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter. It takes a template argument to allow clients to determine statically whether it should allow junk after the numbers or not. (WTF): (WTF::strtod):
wtf/dtoa.h: (WTF):
wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers. (WTF::toDoubleType):

nesting horizontal flexboxes is broken...

Tue, 14 Feb 2012 03:05:07 +0000

Commit by ojan@chromium.org :: r107624 /trunk/ (11 files in 4 dirs):

nesting horizontal flexboxes is broken
https://bugs.webkit.org/show_bug.cgi?id=76867

Reviewed by David Hyatt.

Source/WebCore:

This is copied from RenderDeprecatedFlexibleBox and updated
for RenderFlexibleBox and to handle vertical writing mode.

Tests: css3/flexbox/preferred-widths-orthogonal.html
css3/flexbox/preferred-widths.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::computePreferredLogicalWidths):
rendering/RenderFlexibleBox.cpp: (WebCore::marginWidthForChild): (WebCore): (WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
rendering/RenderFlexibleBox.h: (RenderFlexibleBox): LayoutTests:
css3/flexbox/floated-flexbox-expected.txt:
css3/flexbox/line-wrapping.html: The old results here were wrong because they wrapped the contents of each flex item.
css3/flexbox/preferred-widths-expected.txt: Added.
css3/flexbox/preferred-widths-orthogonal-expected.txt: Added.
css3/flexbox/preferred-widths-orthogonal.html: Added.
css3/flexbox/preferred-widths.html: Added.

Merge r106388.

Tue, 14 Feb 2012 03:02:40 +0000

Commit by lforschler@apple.com on safari-534.54-branch :: r107623 / (4 files in 3 dirs):

Merge r106388.

Crash in RenderFlowThread::setRegionBoxesRegionStyle...

Tue, 14 Feb 2012 02:55:45 +0000

Commit by mihnea@adobe.com :: r107622 /trunk/ (9 files in 5 dirs):

Crash in RenderFlowThread::setRegionBoxesRegionStyle
https://bugs.webkit.org/show_bug.cgi?id=78298

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/set-box-style-in-region-crash.html

We have to make sure that anonymous block objects get their information in RenderFlowThread
removed properly.

dom/Node.cpp: (WebCore::Node::diff): Correct a comment.
rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseAnonymousBoxChild): Remove the information for anonymous block from render flow thread.
rendering/RenderFlowThread.cpp: (WebCore::RenderFlowThread::removeFlowChildInfo): (WebCore): (WebCore::RenderFlowThread::setRegionRangeForBox): Do not set region range if the flow thread does not have regions.
rendering/RenderFlowThread.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::willBeDestroyed): Add an assert to make sure that after we remove an object, there is no remaining info in any render flow thread. LayoutTests:
fast/regions/set-box-style-in-region-crash-expected.txt: Added.
fast/regions/set-box-style-in-region-crash.html: Added.

[chromium] Unreviewed, skip http/tests/navigation/https-in-page-cache.html...

Tue, 14 Feb 2012 02:49:22 +0000

Commit by tony@chromium.org :: r107621 LayoutTests/ (2 files in 2 dirs):

[chromium] Unreviewed, skip http/tests/navigation/https-in-page-cache.html
because we don't enable the page cache in chromium.

platform/chromium/test_expectations.txt:

Add a skeleton ChromiumAndroid port to webkitpy...

Tue, 14 Feb 2012 02:44:41 +0000

Commit by abarth@webkit.org :: r107620 Tools/ (5 files in 2 dirs):

Add a skeleton ChromiumAndroid port to webkitpy
https://bugs.webkit.org/show_bug.cgi?id=78543

Reviewed by Eric Seidel.

This patch just adds an empty ChromiumAndroid port object to webkitpy
and wires it up to the factory objects. An actual implementation will
follow.

Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort):
Scripts/webkitpy/layout_tests/port/chromium_android.py: Added. (ChromiumAndroidPort): (ChromiumAndroidPort.__init__):
Scripts/webkitpy/layout_tests/port/chromium_unittest.py: (ChromiumPortTest.test_all_test_configurations):
Scripts/webkitpy/layout_tests/port/factory.py: (PortFactory):

[chromium] Unreviewed, r107611 enabled layout tests in css3/filters, but some...

Tue, 14 Feb 2012 02:40:25 +0000

Commit by tony@chromium.org :: r107619 LayoutTests/ (2 files in 2 dirs):

[chromium] Unreviewed, r107611 enabled layout tests in css3/filters,
but some are missing results.

platform/chromium/test_expectations.txt:

[chromium] Let WebKit::initialize call InitWebCoreSystemInterface on mac....

Tue, 14 Feb 2012 02:37:49 +0000

Commit by thakis@chromium.org :: r107618 Source/WebKit/chromium/ (ChangeLog src/WebKit.cpp):

[chromium] Let WebKit::initialize call InitWebCoreSystemInterface on mac.
https://bugs.webkit.org/show_bug.cgi?id=78246

This allows removing a bunch of code in chromium land (https://chromiumcodereview.appspot.com/9374020/),
and helps with the component build on mac (InitWebCoreSystemInterface is not an
exported function, and it shouldn't be).

Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm early-returns when it's
called twice, so it's safe to land this change, and remove the calls in client
code in a later CL.

Reviewed by Darin Fisher.

src/WebKit.cpp: (WebKit::initializeWithoutV8):

[chromium] Unreviewed gardening. We don't need to pass...

Tue, 14 Feb 2012 02:34:35 +0000

Commit by tony@chromium.org :: r107617 LayoutTests/ (2 files in 2 dirs):

[chromium] Unreviewed gardening. We don't need to pass
platform/win/inverted-colors/non-composited.html.

platform/chromium/test_expectations.txt:

[chromium] Unreviewed gardening. Rebaselining GPU results. *...

Tue, 14 Feb 2012 02:26:26 +0000

Commit by fischman@chromium.org :: r107616 LayoutTests/ (22 files in 4 dirs):

[chromium] Unreviewed gardening. Rebaselining GPU results.

platform/chromium-gpu-linux/media/controls-after-reload-expected.png:
platform/chromium-gpu-linux/media/controls-strict-expected.png:
platform/chromium-gpu-linux/media/controls-styling-expected.png:
platform/chromium-gpu-linux/media/controls-without-preload-expected.png:
platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png:
platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png:
platform/chromium-gpu-linux/media/video-transformed-expected.png:
platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
platform/chromium-gpu-linux/media/video-zoom-expected.png:
platform/chromium-gpu-mac/media/controls-after-reload-expected.txt: Removed.
platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
platform/chromium-gpu-mac/media/video-playing-and-pause-expected.txt: Removed.
platform/chromium-gpu-win/media/controls-strict-expected.txt: Removed.
platform/chromium-gpu-win/media/controls-styling-expected.txt: Removed.
platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Removed.
platform/chromium-gpu-win/media/video-controls-rendering-expected.png:

Unreviewed, rolling out r107582. http://trac.webkit.org/changeset/107582...

Tue, 14 Feb 2012 02:23:00 +0000

Commit by tony@chromium.org :: r107615 /trunk/ (18 files in 6 dirs):

Unreviewed, rolling out r107582.
http://trac.webkit.org/changeset/107582
https://bugs.webkit.org/show_bug.cgi?id=78349

Broke three inspector interactive_ui_tests

Source/WebCore:

English.lproj/localizedStrings.js:
inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
inspector/front-end/ScriptsNavigator.js: (WebInspector.ScriptsNavigator.prototype._removeUISourceCode.get while): (WebInspector.ScriptsNavigator.prototype._removeUISourceCode): (WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded): (WebInspector.ScriptsPanel.prototype._updateExecutionLine):
inspector/front-end/Settings.js: (WebInspector.ExperimentsSettings):
inspector/front-end/SettingsScreen.js: (WebInspector.SettingsScreen): LayoutTests:
http/tests/inspector/debugger-test.js: (initialize_DebuggerTest):
inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Removed.
inspector/debugger/scripts-combobox-file-selector-history.html: Removed.
inspector/debugger/scripts-file-selector-expected.txt: Removed.
inspector/debugger/scripts-file-selector.html: Removed.
inspector/debugger/scripts-panel-expected.txt:
inspector/debugger/scripts-panel.html:
inspector/debugger/scripts-sorting-expected.txt:
inspector/debugger/scripts-sorting.html:
inspector/debugger/source-frame-count.html:

NRWT's HTTP servers should support additional directories for resources...

Tue, 14 Feb 2012 02:07:09 +0000

Commit by abarth@webkit.org :: r107614 Tools/ (7 files in 4 dirs):

NRWT's HTTP servers should support additional directories for resources
https://bugs.webkit.org/show_bug.cgi?id=78528

Reviewed by Eric Seidel.

This functionality will be used by the Chromium-Android port.

Scripts/webkitpy/layout_tests/port/base.py: (Port.to.start_http_server):
Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__):
Scripts/webkitpy/layout_tests/servers/http_server.py: (Lighttpd.__init__): (Lighttpd._prepare_config):

Source/WebCore: Incorrect children placement in multi-column layout....

Tue, 14 Feb 2012 01:53:44 +0000

Commit by inferno@chromium.org :: r107613 /trunk/ (6 files in 4 dirs):

Source/WebCore: Incorrect children placement in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78160

Reviewed by David Hyatt.

Test: fast/multicol/span/clone-before-after-content-crash.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::clone): no longer need to take care of making children noninline (remove fix r105769) since moveChild functions take care of adding the child properly if type of children differ. this function just makes sure to set the right value of childrenInline property. (WebCore::RenderBlock::splitBlocks): similar to moveChild functions below. (WebCore::RenderBlock::moveChildTo): when child is fullRemoveInsert (across different parents, e.g clones), we should use addChild function to make sure it handles the case of different type of children between fromBlock and toBlock correctly (specifically making children non-inline/wrapping inline children under anonymous blocks.). (WebCore::RenderBlock::moveChildrenTo):
rendering/RenderBlock.h: (RenderBlock): (WebCore::RenderBlock::moveAllChildrenTo): Rename to->toBlock. (WebCore::RenderBlock::moveChildrenTo): Rename to->toBlock. LayoutTests: Incorrect children placement in multi-column layout. https://bugs.webkit.org/show_bug.cgi?id=78160 Reviewed by David Hyatt.
fast/multicol/span/clone-before-after-content-crash-expected.txt: Added.
fast/multicol/span/clone-before-after-content-crash.html: Added.